[NEAT-487] Aggegated view of issues #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
doctrino
commented
Oct 31, 2024
•
doctrino
commented
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
doctrino
force-pushed
the
issue-visualization
branch
from
6f9ed93
to
023e726
Compare
nikokaoja
approved these changes
Nov 3, 2024
| @overload | ||
| def __call__( | ||
| self, | ||
| search: str | None = None, |
|
|
||
| if issues and search is not None: | ||
| unique_types = {type(issue).__name__ for issue in issues} | ||
| closest_match = set(difflib.get_close_matches(search, unique_types)) |
There was a problem hiding this comment.
will this return partial matches ? what about fuzzy instead ? https://github.com/seatgeek/thefuzz or using cognite sdk entity matching ?
There was a problem hiding this comment.
This is a very simple way of using the standard library without any extra dependencies to get a slightly better search experience. Suggest we avoid any extra dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.