[NEAT-492] 🦟Core import bug #675
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
| @@ -395,6 +400,43 @@ def _gather_properties( | |||
|
|
|||
| return container_properties_by_id, view_properties_by_id | |||
|
|
|||
| @staticmethod | |||
| def _gather_properties_with_parents( | |||
There was a problem hiding this comment.
I suggest you move this under DMS Analysis module
There was a problem hiding this comment.
| def _gather_properties_with_parents( | |
| def _gather_properties_with_ancestors( |
There was a problem hiding this comment.
Leverage cognite.neat._utils.rdf_.get_inheritance_path
There was a problem hiding this comment.
I am using it in BaseAnalysis module under classes_with_properties where you can pass consider_inheritance flag
There was a problem hiding this comment.
The difference is that here you also set the child view as the view for all properties. Do you still think we should expose it in the DMSAnalysis or keep it as a private implementation detail?
| @@ -120,7 +120,11 @@ def to_schema(self) -> DMSSchema: | |||
|
|
|||
| containers = self._create_containers(container_properties_by_id, rules.enum) # type: ignore[arg-type] | |||
|
|
|||
| views, view_node_type_filters = self._create_views_with_node_types(view_properties_by_id) | |||
| view_properties_with_parents_by_id = self._gather_properties_with_parents(view_properties_by_id, rules.views) | |||
There was a problem hiding this comment.
This will return all the properties that are "inherited" from ancestors views , so maybe called this
view_ancestor_properties to make dist. between properties specifically defined for given view, and those coming from implements
| @@ -198,6 +202,7 @@ def _create_spaces( | |||
| def _create_views_with_node_types( | |||
| self, | |||
| view_properties_by_id: dict[dm.ViewId, list[DMSProperty]], | |||
| view_properties_with_parents_by_id: dict[dm.ViewId, list[DMSProperty]], | |||
There was a problem hiding this comment.
see my naming suggestion
# Conflicts: # cognite/neat/_constants.py # cognite/neat/_rules/analysis/_dms.py # cognite/neat/_rules/transformers/_converters.py # cognite/neat/_session/_prepare.py
| @@ -395,6 +400,43 @@ def _gather_properties( | |||
|
|
|||
| return container_properties_by_id, view_properties_by_id | |||
|
|
|||
| @staticmethod | |||
| def _gather_properties_with_parents( | |||
There was a problem hiding this comment.
I am using it in BaseAnalysis module under classes_with_properties where you can pass consider_inheritance flag
Before
After