Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup fix for cache & global site setttings handling #1525

Merged
merged 9 commits into from
Jan 26, 2025

Conversation

Oaphi
Copy link
Member

@Oaphi Oaphi commented Jan 26, 2025

This PR follows up #1517 and #1516 ensuring that:

  • global site settings clear cache for all communities, not just the current one;
  • adds proper methods for SiteSettingsController's actions (access?, audit_update, clear_cache, do_create methods);
  • adds global? method on the SiteSetting model;
  • fixes overflow of site setting values when the <details> element is opened (it's a crude fix for now via overflow-wrap - we should make HTML-valued settings use code blocks instead);

Site setting value overflow before the fix:

Screenshot from 2025-01-26 22-13-56

And lack thereof after:

Screenshot from 2025-01-26 22-23-42

@Oaphi Oaphi requested review from cellio and ArtOfCode- January 26, 2025 19:25
@Oaphi Oaphi self-assigned this Jan 26, 2025
@Oaphi Oaphi added the area: backend Changes to server-side code label Jan 26, 2025
@Oaphi Oaphi requested a review from a team January 26, 2025 19:27
cellio

This comment was marked as resolved.

@cellio
Copy link
Member

cellio commented Jan 26, 2025

LGTM - tested and it works. I defer to Art for code review.

@ArtOfCode- ArtOfCode- merged commit 7996b4b into develop Jan 26, 2025
7 checks passed
@ArtOfCode- ArtOfCode- deleted the 0valt/cache-fixes branch January 26, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Changes to server-side code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants