Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user on ability grant #1519

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Notify user on ability grant #1519

merged 7 commits into from
Jan 17, 2025

Conversation

ArtOfCode-
Copy link
Member

Closes #1419

Adds a notification to the user on granting an ability. Also some related code cleanup.

@ArtOfCode- ArtOfCode- added area: backend Changes to server-side code type: change request New feature or request priority: medium labels Jan 17, 2025
@ArtOfCode- ArtOfCode- requested a review from a team January 17, 2025 17:11
app/models/community_user.rb Outdated Show resolved Hide resolved
Copy link
Member

@Oaphi Oaphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC'ing just in case we accidentally get it merged without solving the 404 issue as otherwise - LGTM.

Copy link
Member

@Oaphi Oaphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, no 404 after the fix - LGTM

@Oaphi Oaphi merged commit e14b2a0 into develop Jan 17, 2025
7 checks passed
@Oaphi Oaphi deleted the art/1419-ability-notifications branch January 17, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Changes to server-side code priority: medium type: change request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send inbox notification when an ability is earned/granted
2 participants