Theme #60
Theme #60
Conversation
make text color black for .notice
Blackish background don't show black text
|
Um... where do you have the source files (/src) for these changes? If you don't include them, all modifications you made would be deleted at the next build. |
|
Maybe, i didn’t understand you properly. Are you looking where I worked? https://github.com/Istiakshovon/co-design/tree/Theme the changes are available in that branch. I have those code in my system also |
There was a problem hiding this comment.
@luap42 is right. You've changed the dist/codidact.css file with your changes, but nothing else. You need to make changes in the files under the src/ directory, then run the build scripts to push them into codidact.css when that's done. Otherwise, next time we run a build all your changes will disappear.
|
@ArtOfCode- Where (Which line you changed) you requested to make changes? It's looking like you had made changes to Light Theme. When I was running your code I saw some weird text (Unicode) in post and lot of places. And, It wasn't available in dark theme.
|
|
That's an encoding bug, don't know where from. There's no specific line you need to change - you need to move all your dark theme code into the appropriate files under src/ and then build the project to compile them into codidact.css. |
|
@ArtOfCode- Please! Check that I am doing it correct or not. If yes! Than, I will commit other files and, build the project.. |
|
You've got the right files now, yep. Some tips:
|
I didn't have lots of color code for dark theme. That's why I thought all those color could fit in a single page.
When I was working on the page. When I used .is-active it wasn't working for me. So that, I wrote .active Since, the page is nearly done so, I am changing it again.
Since, the dark theme applied to CoDesign also hence, the background color should be black(ish) and, text color should be white.
|
Oops! I forgot to made changes to codidact.scss. i will try to work on it again ASAP. |
Resolves : #57 and, codidact/qpixel#565
Dark theme
Umm!
Code area (pre tag) and, user-card-meta's background is changed from cd.com/assets/stylesheets/application.scss That's why I didn't make changes to them in codidact.scss.button is-muted is-outlined is-active(activity tab) is from codidact.scss. But, when I was copy-pasting those code I forgot to change their color and, background-color. I will change check it again.Currently, I am using separated lines just to understand those code. In my last commit I will write them in a line (or, mix them).
Found a problem.... :
texts isn't white color in fields.. And, .notice .is-warning color is white.....(Maybe, now I can say that no more work is needed in CoDesign)(activity tab should be black (leaving it as it is for now))(Check following picture and, comment if you see any problem)New changes
Note : Diff is showing that I made changes to light theme also. Usually, I make changes to light theme. It's all over dark theme.
To test (If you are using Linux) : If you are using Chrome/Chromium than, run that following way
You won't face problem for Firefox. I am not sure of Vilvera and, some others (Safari etc). Read the thread to know why you are facing the problem.
Currently, most of worked are done. I guess, there's nothing "left". Usually, it is possible to change color for each category's header. I would request someone else to make changes for category's header (it's in line 17) (You can make PR in the repo if you want). Current, category-header color isn't bad for dark theme either. But, new color for dark theme is very good.
Ohh! Sorry I didn't know changing name of branch will delete PR