Skip to content

Commit

Permalink
chore(certora): add invariant that totalSent is <= totalReceived
Browse files Browse the repository at this point in the history
This commit adds an invariant that verifies `marketplaceTotals.sent <=
marketplceTotals.received`.

The invariant relies on the `Token.totalSupply()` which has previously
been verified to be the sum of all balances.

The invariant uses `<=` as there could be donations sent to the
marketplace.

Closes #132
  • Loading branch information
0x-r4bbit committed Oct 21, 2024
1 parent c3e4fdd commit b413d77
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions certora/specs/Marketplace.spec
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,22 @@ invariant cancelledSlotAlwaysHasCancelledRequest(env e, Marketplace.SlotId slotI
currentContract.slotState(e, slotId) == Marketplace.SlotState.Cancelled =>
currentContract.requestState(e, slotIdToRequestId[slotId]) == Marketplace.RequestState.Cancelled;

// STATUS - in progress (fails on constructor state due to a strange behaviour in the tool)
// _marketplaceTotals.received - _marketplaceTotals.sent == tokenBalanceOfContract
// https://prover.certora.com/output/3106/4e6cac8055ac45bb92840e14d9b095eb/?anonymousKey=655a42ca6306a023db78914d5a188d8ec2882771
invariant totalSentIsLessThanOrEqualTotalReceived()
totalReceived - totalSent <= to_mathint(Token.balanceOf(currentContract))
{
preserved fillSlot(MarketplaceHarness.RequestId requestId, uint256 slotIndex, MarketplaceHarness.Groth16Proof proof) with (env e2) {
require e2.msg.sender != currentContract;
requireInvariant totalSupplyIsSumOfBalances();
}
preserved requestStorage(MarketplaceHarness.Request request) with (env e3) {
require e3.msg.sender != currentContract;
requireInvariant totalSupplyIsSumOfBalances();
}
}

/*--------------------------------------------
| Properties |
--------------------------------------------*/
Expand Down

0 comments on commit b413d77

Please sign in to comment.