initial OOD implementation #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rupeshiya
force-pushed
the
design_pattern
branch
2 times, most recently
from
6f6cc0d to
395bef4
Compare
|
Best way would have been going one file at a time of functionality wise. 😔 |
|
@devesh-verma Is there anything wrong? |
Rupeshiya
force-pushed
the
design_pattern
branch
from
395bef4 to
9302bc2
Compare
Rupeshiya
force-pushed
the
design_pattern
branch
from
9302bc2 to
0547772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request template
about: Describe the PR.
title: ''
labels: ''
assignees: ''
Problem
Github Issue Number: #159
As of now, the codebase does not follow any design pattern, so it's pretty hard to make it maintainable and flexiblel_
Solution of problem
Refactor the backend codebase by following the Object-oriented design pattern like Singleton classes, factory classes
Type of Change
[ ] Bug fix
[✓] New Feature
[ ] Development of UI/UX prototypes
[ ] Small refactor
[ ] Change in Documentation
Checklist
[✓] My code follows the same style as the codebase
[ ] My Code change requires a change in documentation
[ ] I have updated the Readme accordingly
[✓] I made PR against development branch
[ ] I have run the test cases locally and it's passing.
[✓] I have squashed my commits