Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container configurations #141

Merged
merged 7 commits into from
Jul 8, 2020

Conversation

kmehant
Copy link
Contributor

@kmehant kmehant commented Jul 5, 2020

Signed-off-by: K mehant [email protected]

Issue: #140

Todo list:

  • container config for publishing
  • container config for local development
  • GitHub workflow for build and push container image
  • docker-compose file to setup the complete project instantly (docker-compose up command)
  • Create docker hub account for Codeuino Donut
  • Add GitHub secrets DOCKER_USERNAME and DOCKER_PASSWORD to this repository
  • Write docs for developers to make use of development docker file

Dockerfile.dev Outdated Show resolved Hide resolved
@kmehant
Copy link
Contributor Author

kmehant commented Jul 5, 2020

@vaibhavdaren @jaskiratsingh2000 @devesh-verma
Please once look at my TODO list #141 (comment) for this PR. We are left with unchecked items only. In which docs are part of it. Where shall we write small documentation on usage of these images? The other two unchecked TODOs is to be carried out by the project maintainers.

@jaskiratsingh2000
Copy link
Member

jaskiratsingh2000 commented Jul 5, 2020 via email

@vaibhavdaren
Copy link
Member

DATABASE_URL="mongodb://mongo:27017/donut-development"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to switch between hostnames mongo and localhost for container and normal setup respectively.

npm cache clean --force --loglevel=error

# Start the server
CMD [ "pm2", "start", "./bin/www", "--time", "--no-daemon" ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pm2 process manager would give another wrapping for our node server to keep running all time (production use case)

@kmehant
Copy link
Contributor Author

kmehant commented Jul 6, 2020

@devesh-verma @jaskiratsingh2000 @vaibhavdaren Please review!. I have tested locally!

@kmehant kmehant changed the title [WIP] Add container configurations Add container configurations Jul 8, 2020
@devesh-verma devesh-verma merged commit 0708a2c into codeuino:development Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants