-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container configurations #141
Conversation
Signed-off-by: K mehant <[email protected]>
Signed-off-by: K mehant <[email protected]>
@vaibhavdaren @jaskiratsingh2000 @devesh-verma |
We maintain every thing through Gitbook documentation. I would be able to
help you more by tomorrow.
…On Sun, 5 Jul 2020, 10:23 pm Mehant Kammakomati, ***@***.***> wrote:
@vaibhavdaren <https://github.com/vaibhavdaren> @jaskiratsingh2000
<https://github.com/jaskiratsingh2000> @devesh-verma
<https://github.com/devesh-verma>
Please once look at my TODO list #141 (comment)
<#141 (comment)>
for this PR. We are left with unchecked items only. In which docs are part
of it. Where shall we write small documentation on usage of these images?
The other two unchecked TODOs is to be carried out by the project
maintainers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#141 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOBHK5SBK676FP3BAFS3K3R2CVY3ANCNFSM4OQZOMJQ>
.
|
https://medium.com/lucjuggery/from-env-variables-to-docker-secrets-bc8802cacdfd |
Signed-off-by: K mehant <[email protected]>
DATABASE_URL="mongodb://mongo:27017/donut-development" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to switch between hostnames mongo
and localhost
for container and normal setup respectively.
npm cache clean --force --loglevel=error | ||
|
||
# Start the server | ||
CMD [ "pm2", "start", "./bin/www", "--time", "--no-daemon" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pm2
process manager would give another wrapping for our node server to keep running all time (production use case)
@devesh-verma @jaskiratsingh2000 @vaibhavdaren Please review!. I have tested locally! |
Signed-off-by: K mehant <[email protected]>
Signed-off-by: K mehant <[email protected]>
Signed-off-by: K mehant [email protected]
Issue: #140
Todo list:
DOCKER_USERNAME
andDOCKER_PASSWORD
to this repository