-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerize complete Donut project #140
Comments
@jaskiratsingh2000 @devesh-verma |
@devesh-verma @jaskiratsingh2000 As Jaskirat raised a question regarding using various OSs, |
Thanks, @kmehant for writing this up. I was about to ask for this. This documentation reflects that it can be made for windows https://docs.docker.com/docker-for-windows/ and for Mac too https://docs.docker.com/docker-for-mac/install/ Also, do you think that this should be in a new repo or in this repo only? |
@jaskiratsingh2000 My concern was if you are planning to use docker containers to test Donut on various OSs (I guess not required for Web applications) in those cases we need different base images which is not possible for containers (as they can have only Linux based base images as of now) |
Both the ways it is completely fine for me, @devesh-verma thoughts? |
The only concern for me would be that how actually we can test "Donut" on different OS?
@kmehant what's the best way? |
@jaskiratsingh2000 are there any OS dependent features or components part of Donut? |
its a web app. |
I would say same repo |
Okay, as there are no OS dependent features then testing on different OS seems not required with the testing pipeline |
Ummm, okay
…On Sat, 4 Jul 2020, 5:20 pm Mehant Kammakomati, ***@***.***> wrote:
its a web app.
Okay, as there are no OS dependent features then testing on different OS
seems not required with the testing pipeline
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#140 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOBHKYWWILPVVQYZ5BBWVDRZ4JPLANCNFSM4OQLCCCQ>
.
|
Okay, then good to go right? |
@devesh-verma @jaskiratsingh2000 If we can decide upon the usage of containers. I can start writing the configurations.
|
Go ahead with option 1 and 3, which will serve our purpose. @kmehant |
Is your feature request related to a problem? Please describe.
We need to write container configurations for the Donut project (for both development and production purposes)
Describe the solution you'd like
Write container configurations compatible with docker container engine and with pipeline concerned for linting, testing, and deployment purposes.
The text was updated successfully, but these errors were encountered: