Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vite-preact and vite-preact-ts templates #1000

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Sep 12, 2023

What kind of change does this pull request introduce?

feature

What is the current behavior?

No preact templates

What is the new behavior?

Added vite-preact and vite-preact-ts

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

Tested locally on Storybook

Checklist

  • Documentation;
  • Storybook (if applicable);
  • Tests;
  • Ready to be merged;

@codesandbox
Copy link

codesandbox bot commented Sep 12, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Sep 12, 2023

@ocavue is attempting to deploy a commit to the CodeSandbox Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 12, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 41b25e4:

Sandbox Source
Sandpack Configuration
sandpack-run-stale-value Configuration

@ocavue ocavue marked this pull request as ready for review September 12, 2023 08:39
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sandpack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 7:49pm

@danilowoz
Copy link
Member

Cool! Would you mind adding the preact logo to the documentation?
https://github.com/codesandbox/sandpack/blob/main/website/docs/src/components/TemplatesList.jsx#L6-L27

@ocavue
Copy link
Contributor Author

ocavue commented Sep 26, 2023

@danilowoz Logo has been added

@danilowoz
Copy link
Member

Thanks!!!!

@danilowoz danilowoz merged commit 8789aa9 into codesandbox:main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants