Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add support for Rax #3441

Closed
wants to merge 11 commits into from
Closed

Conversation

fyangstudio
Copy link

@fyangstudio fyangstudio commented Feb 1, 2020

Support Rax: https://rax.js.org/

What kind of change does this PR introduce?

Rax starter template feature #3345

What is the current behavior?

No Rax 😞

What is the new behavior?

Get started with Rax in CodeSandbox

Checklist

  • Documentation
  • Testing
  • Icon
  • Template
  • Importer
  • Ready to be merged
  • Added myself to contributors table

@lbogdan
Copy link
Contributor

lbogdan commented Feb 1, 2020

Build for latest commit b1c2132 failed.

@fyangstudio
Copy link
Author

fyangstudio commented Feb 1, 2020

@lbogdan lbogdan temporarily deployed to pr3441 February 3, 2020 01:55 Inactive
@CompuIves
Copy link
Member

Hey! Thanks for this contribution. We recently changed how we handle templates, right now we have a list of "templates" and a list of "environments". An environment is something that redefines how the sandbox is executed and which devtools are shown.

I think in this case, for Rax, we can reuse the node environment and say to the importer to make everything with the Rax template a node environment. Then we can add Rax to the list of official templates in our Template Modal by linking the sandbox.

So my approach would be this:
Merge the other PRs that you've opened, and then add the Rax example you mentioned here to our official template list. This way it will show up as an official template.

@fyangstudio
Copy link
Author

Hey! Thanks for this contribution. We recently changed how we handle templates, right now we have a list of "templates" and a list of "environments". An environment is something that redefines how the sandbox is executed and which devtools are shown.

I think in this case, for Rax, we can reuse the node environment and say to the importer to make everything with the Rax template a node environment. Then we can add Rax to the list of official templates in our Template Modal by linking the sandbox.

So my approach would be this:
Merge the other PRs that you've opened, and then add the Rax example you mentioned here to our official template list. This way it will show up as an official template.

Thanks for your reply. Can I have a preview of the dev server if I reuse the node environment? I see that the current node environment preview is the log of node, we need the developers to preview their Web App.
image

@SaraVieira SaraVieira mentioned this pull request Feb 13, 2020
7 tasks
@yacheng
Copy link

yacheng commented Mar 2, 2020

How to reuse the node environment and whether there are documents?

@fyangstudio
Copy link
Author

We recently changed how we handle templates, right now we have a list of "templates" and a list of "environments".

When can this project be done? Where can i see the new documentation?

@CompuIves

@github-actions
Copy link

github-actions bot commented Sep 4, 2020

This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Sep 4, 2020
@fyangstudio fyangstudio closed this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants