-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove default ServiceMonitor #1132
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Francesco Ilario <[email protected]>
87496cb
to
976b4df
Compare
Signed-off-by: Francesco Ilario <[email protected]>
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 🥇
/lgtm |
@filariow any specific reason for putting it on hold? |
Yeah, sorry, I forgot to mention it. I'd like to merge redhat-appstudio/infra-deployments#5441 before this one |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, filariow, MatousJobanek, mfrancisc, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
==========================================
- Coverage 79.52% 79.51% -0.02%
==========================================
Files 80 80
Lines 8087 8087
==========================================
- Hits 6431 6430 -1
- Misses 1471 1472 +1
Partials 185 185 |
Signed-off-by: Francesco Ilario [email protected]