Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default ServiceMonitor #1132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

filariow
Copy link
Contributor

Signed-off-by: Francesco Ilario [email protected]

Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
@filariow filariow changed the title update default ServiceMonitor remove default ServiceMonitor Jan 31, 2025
@filariow
Copy link
Contributor Author

/hold

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 🥇

@MatousJobanek
Copy link
Contributor

/lgtm

@alexeykazakov
Copy link
Contributor

@filariow any specific reason for putting it on hold?

@filariow
Copy link
Contributor Author

@filariow any specific reason for putting it on hold?

Yeah, sorry, I forgot to mention it. I'd like to merge redhat-appstudio/infra-deployments#5441 before this one

Copy link

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, MatousJobanek, mfrancisc, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,mfrancisc,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Feb 4, 2025
Copy link

openshift-ci bot commented Feb 4, 2025

New changes are detected. LGTM label has been removed.

Copy link

sonarqubecloud bot commented Feb 4, 2025

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.51%. Comparing base (fa50881) to head (cfa7029).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
- Coverage   79.52%   79.51%   -0.02%     
==========================================
  Files          80       80              
  Lines        8087     8087              
==========================================
- Hits         6431     6430       -1     
- Misses       1471     1472       +1     
  Partials      185      185              

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants