Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variables in axis text #174

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

kwapik
Copy link

@kwapik kwapik commented Jan 23, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced chart axis configuration to support template variable expansion.

Copy link

coderabbitai bot commented Jan 23, 2024

Walkthrough

The update involves a modification to the Grafana UI's axis configuration. A new property, expandTemplateVars: true, has been introduced to the axis settings within the addAxisConfig function, allowing for the expansion of template variables.

Changes

File Path Change Summary
.../grafana-ui/src/options/builder/... Added expandTemplateVars: true to axis settings.

🐇
To the axis we add a twist,
expandTemplateVars can't be missed.
In the code, it takes its stance,
Making Grafana's graphs enhance. 🌟


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f9d3fc1 and 65bbaaa.
Files selected for processing (1)
  • packages/grafana-ui/src/options/builder/axis.tsx (1 hunks)
Additional comments: 1
packages/grafana-ui/src/options/builder/axis.tsx (1)
  • 42-42: The addition of expandTemplateVars: true to the settings object enables template variable expansion in axis labels. Ensure that this new feature is documented, and consider adding a test case to verify that template variables are expanded as expected.

@kwapik kwapik enabled auto-merge (squash) January 23, 2024 13:34
@kwapik kwapik merged commit 33994b4 into fluxninja_micro_frontends Jan 25, 2024
1 check passed
@kwapik kwapik deleted the kwapik/axis-variables branch January 25, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants