Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgns2223
reviewed
Sep 30, 2024
Comment on lines
+14
to
+15
| const [isLoggedIn, setIsLoggedIn] = useState<boolean>(false); | ||
| const [isLogout, setIsLogout] = useState<boolean>(false); |
There was a problem hiding this comment.
isLoggedIn과 isLoggedOut은 서로 상반되는 상태라 하나의 상태로 관리해도 될 것 같습니다.
따로 상태를 선언하신 이유가 있을까요? isLoggedIn이 false이면 로그아웃인걸로 해도 될 것 같아요.
| @@ -6,6 +6,9 @@ import "@/styles/global.css"; | |||
|
|
|||
| import type { AppProps } from "next/app"; | |||
| import Head from "next/head"; | |||
| import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; | |||
|
|
|||
| const queryClient = new QueryClient(); | |||
There was a problem hiding this comment.
query client를 useState의 state에 선언해두면 유저 마다 캐싱을 확실히 할 수 있다고 합니다.
아래의 내용을 읽어보시길 바랍니다 !
| console.log(sortOrder, searchKeyword); | ||
|
|
||
| // 전체 게시글 | ||
| const {data: articlesData, isLoading: isAllLoading, isError: isAllError} = useQuery({ |
There was a problem hiding this comment.
data, isLoading, isError` 상태를 각각 다 다루고 계시네요. 잘하셨어요 ~
Comment on lines
+69
to
+85
| const handleSignUp = async (e: FormEvent<HTMLFormElement>) => { | ||
| e.preventDefault(); | ||
|
|
||
| try { | ||
| const isSignUp = await postSignUp({ | ||
| email: signUpEmail, | ||
| nickname: signUpNickname, | ||
| password: signUpPassword, | ||
| passwordConfirmation: signUpPasswordCheck, | ||
| }) | ||
| if(isSignUp) { | ||
| router.push('/login'); | ||
| } | ||
| } catch (error) { | ||
| console.error('회원가입 에러', error) | ||
| } | ||
| } |
There was a problem hiding this comment.
이런 부분도 react-query를 활용해서 mutation hook을 이용하면 서비스 전반적으로 react-query를 써서 일관성이 있을 것 같고, 코드도 패턴이 일관성이 있을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
중고마켓
상품 상세
상품 등록
주요 변경사항
스크린샷
멘토에게