-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[나윤주] sprint10 #294
The head ref may contain hidden characters: "Next-\uB098\uC724\uC8FC-sprint10"
[나윤주] sprint10 #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이번엔 크게 코멘트 달만한 부분이 보이지 않네요!
윤주님 몸 잘 챙겨가면서 공부하세요!
항상 열심히 잘 해주고 계십니다 👍 이번 한주도 화이팅해요!
}; | ||
|
||
const handleImageDelete = () => { | ||
setImagePreviewUrl(""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
초기화의 목적이라면 null로 해주는 것도 괜찮겠네요!
import React from "react"; | ||
import styles from "./Button.module.scss"; | ||
|
||
type ButtonSize = "sm" | "md" | "lg"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
타입으로 지정해주시는 것도 너무 좋네요 👍
.image-add-wrap { | ||
display: flex; | ||
gap: 25px; | ||
@media (max-width: 1200px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저번에 보여드렸던 것처럼 _responsive.scss 파일에 이런 media 구문을 @mixin으로 함수화 시켜서 정리해주시면 편할 거에요 👍
스프린트 10미션
요구사항
체크리스트 [기본]
상품 등록 페이지
상품 상세 페이지
스크린샷
멘토에게