Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Aug 3, 2024
| <BrowserRouter> | ||
| <Routes> | ||
| <Route path="/" element={<RootLayout />}> | ||
| <Route index></Route> |
There was a problem hiding this comment.
컴포넌트가 단독으로 쓰일때는 <Route /> 이런식으로 쓸 수 있습니다.
| @@ -0,0 +1,51 @@ | |||
| const BASE_URL = "https://panda-market-api.vercel.app"; | |||
There was a problem hiding this comment.
base url은 .env 파일에 넣고 .gitignore에 추가해서 깃에 올라오지 않게 해주시면 보안상 이점이 있습니다.
| } | ||
|
|
||
| export async function getProducts({ | ||
| order = "recent", |
There was a problem hiding this comment.
recent 같은 값은 상수로 관리해주시면 좋습니다.
| import "./Button.css"; | ||
|
|
||
| interface ButtonProps { | ||
| children?: ReactNode; |
There was a problem hiding this comment.
children은 타입으로 넘겨주시지 않아도 사용하실 수 있습니다.
| @@ -0,0 +1,72 @@ | |||
| import { useEffect, useState } from "react"; | |||
| import { getComment } from "../../api"; | |||
There was a problem hiding this comment.
alias path를 사용해보시는 것을 추천드립니다.
Comment on lines
+59
to
+61
| items.map((item) => { | ||
| return <CommentListItem key={item.id} item={item} />; | ||
| }) |
There was a problem hiding this comment.
return이 한줄인 경우는 다음과 같이 생략해서 작성하실 수 있습니다.
items.map((item) =>
<CommentListItem key={item.id} item={item} />
)
Comment on lines
+22
to
+25
| const [totalCount, setTotalCount] = useState(1); | ||
| const [currentPage, setCurrentPage] = useState(1); | ||
| const [pageSize, setPageSize] = useState(10); | ||
| const [totalPages, setTotalPages] = useState(0); |
There was a problem hiding this comment.
이렇게 관련 있는 상태끼리는 하나의 객체로 묶어서 관리해주시는 것도 좋습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
멘토에게