Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorpoQ
added
매운맛🔥
Jaeheon96
pushed a commit
to Jaeheon96/8-Sprint-Mission
that referenced
this pull request
Aug 2, 2024
…ithub-actions [Fix] delete merged branch github action
arthurkimdev
reviewed
Aug 5, 2024
Comment on lines
+4
to
+11
| /** | ||
| * 태그 리스트 | ||
| * | ||
| * @param {Array} tags - 태그 배열 | ||
| * @param {function} onDelete - 태그가 지워질 때 실행할 함수 | ||
| * @param {boolean} canDelete - 태그를 지울 수 있으면 X 아이콘 표시 | ||
| * @returns {JSX.Element} - 태그 리스트 컴포넌트 | ||
| */ |
There was a problem hiding this comment.
아래코드 처럼 변경할 수 있겠네요! 😸
type Tag = string;
type TagListProps = {
tags: Tag[];
onDelete: (tag: Tag) => void;
canDelete: boolean;
};
arthurkimdev
reviewed
Aug 5, 2024
Comment on lines
+3
to
+8
| /** | ||
| * 상품 정보 여럿을 읽는 함수 | ||
| * @param {number} [page='1'] - 페이지 번호 (선택) | ||
| * @param {number} [pageSize='10'] - 페이지 당 상품 수 (선택) | ||
| * @param {string} [orderBy='recent'] - 정렬 기준 (선택) | ||
| * @param {string} [keyword] - 검색 키워드 (선택) |
There was a problem hiding this comment.
여기선 이렇게 유니온 타입(Union Type) 사용해서 정의할 수 있겠어요.
type OrderBy = 'recent' | 'favorite';
type GetProductsParams = {
page?: number;
pageSize?: number;
orderBy?: OrderBy;
keyword?: string;
};
arthurkimdev
reviewed
Aug 5, 2024
Comment on lines
+7
to
16
| * Button 컴포넌트 | ||
| * | ||
| * @param {string} className - 버튼 클래스 이름 | ||
| * @param {'small'|'medium'|'large'} [size='small'] - 버튼의 크기 | ||
| * @param {'42'|'48'} [height='42'] - 버튼의 높이 (size가 small일 때만 사용) | ||
| * @param {'blue'|'white'} [theme='blue'] - 버튼의 테마 (size가 small이고 height가 48일 때만 white 사용 가능) | ||
| * @param {string} [to] - Link 태그로 사용될 경우 이동할 경로 | ||
| * @param {React.ReactNode} children - 버튼 내부의 내용 | ||
| * @returns {JSX.Element} - 버튼 컴포넌트 | ||
| */ |
There was a problem hiding this comment.
위에 param 값들이 아래처럼 Type으로 명시될 수 있어요.
type ButtonSize = 'small' | 'medium' | 'large';
type ButtonHeight = '42' | '48';
type ButtonTheme = 'blue' | 'white';
type ButtonProps = {
className?: string;
size?: ButtonSize;
height?: ButtonHeight;
theme?: ButtonTheme;
to?: string;
children: React.ReactNode;
};
arthurkimdev
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
스크린샷
멘토에게