Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 3, 2024 00:15
…rint-Mission into React-나윤주-sprint7
Taero-Kim
approved these changes
Jul 9, 2024
| try { | ||
| const products = await getProducts({ orderBy, page, pageSize }); | ||
| setProducts(products.list); | ||
| setTotalPageNum(Math.ceil(products.totalCount / pageSize)); |
There was a problem hiding this comment.
p4;
totalPageNum은 products와 pageSize를 deps로 가지는 useMemo로 관리해도 좋을 것 같아요!
| return product.trim() !== '' && content.trim() !== '' && price !== 0 && tag.length > 0; | ||
| }, [values]); | ||
|
|
||
| const handleChange = useCallback((name, value) => { |
There was a problem hiding this comment.
p4;
handleChangeFormValues 등의 함수명이면 더 직관적일 것 같아요!
|
요정도만 해도 잘하셨어요! 앞으로 프로젝트에서 요렇게 연습하셨던게 도움이 많이 될거에요! hook도 잘 작성하셨어요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
스프린트 7미션
요구사항
기본
상품 상세
=> favoriteCount : 하트 개수
=> images : 상품 이미지
=> tags : 상품태그
=> name : 상품 이름
=> description : 상품 설명
상품 문의 댓글
=> image : 작성자 이미지
=> nickname : 작성자 닉네임
=> content : 작성자가 남긴 문구
=> description : 상품 설명
=> updatedAt : 문의글 마지막 업데이트 시간
스크린샷
멘토에게