Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Jun 30, 2024
| `https://panda-market-api.vercel.app/products?page=1&${query}` | ||
| ); | ||
| export async function getProducts({ page, pageSize, order }) { | ||
| const apiUrl = process.env.REACT_APP_API_URL; |
There was a problem hiding this comment.
닷엔브 활용해주신거 좋네요. 추가로 보통 baseURL이라는 이름도 많이 사용합니다!
Comment on lines
+4
to
+9
| const [formData, setFormDate] = useState({ | ||
| name: "", | ||
| info: "", | ||
| price: "", | ||
| tag: "", | ||
| }); |
There was a problem hiding this comment.
폼으로 관련이 있는 상태끼리 객체로 관리 하시는 점 좋네요.
Comment on lines
+39
to
+53
| const validAddItem = () => { | ||
| // 유효성 검사 | ||
| if ( | ||
| formData.name !== "" && | ||
| formData.info !== "" && | ||
| formData.price !== "" && | ||
| formData.tag !== "" | ||
| ) { | ||
| setAddItemBtn("on"); | ||
| setBtnDisabled(false); | ||
| } else { | ||
| setAddItemBtn(""); | ||
| setBtnDisabled(true); | ||
| } | ||
| }; |
There was a problem hiding this comment.
현재 방식과 큰 차이는 없지만, 조금 더 역할을 구분해주시는 방법도 추천드립니다. 예를 들어서 유효성 검사하는 함수 내부에서는
formData.name !== "" &&
formData.info !== "" &&
formData.price !== "" &&
formData.tag !== ""
이 로직에 대한 결과만 반환하고 useEffect 내부에서 이 함수의 결과를 보고 setState가 일어나는 방식으로요!
Comment on lines
+55
to
+58
| useEffect(() => { | ||
| // input 데이터 변경 될때마다 유효성 검사 실행 | ||
| validAddItem(); | ||
| }, [formData]); |
There was a problem hiding this comment.
상태에 따라서 매번 유효성 검사해주시는 로직을 useEffect를 활용해서 잘 작성해주셨네요!
Comment on lines
+19
to
+20
| const recent = "recent"; | ||
| const favorite = "favorite"; |
There was a problem hiding this comment.
보통 상수로 관리할때 상수라는 점을 표현하기 위해 변수명으로 대문자를 많이 사용합니다. RECENT 이런식으로요!
Comment on lines
+19
to
+26
| <Routes> | ||
| <Route path="/" element={<Home />} /> | ||
| <Route path="/Login" element={<Login />} /> | ||
| <Route path="/Signup" element={<Signup />} /> | ||
| <Route path="/Items" element={<Items />} /> | ||
| <Route path="/AddItem" element={<AddItem />} /> | ||
| <Route path="*" element={<NotFoundPage />} /> | ||
| </Routes> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
상품등록
심화
주요 변경사항
스크린샷
멘토에게