Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devym-37
approved these changes
Jul 2, 2024
| setAllLinks(AllLinks.data.folder); | ||
| } | ||
|
|
||
| const { data: FoldersData } = useQuery({ | ||
| queryKey: ["Folders"], |
There was a problem hiding this comment.
query키는 추후에 많아 질 수 있고, 프로젝트상 겹칠 수 있는 여지가 있어서, 따로 queryKey를 관리하실 수 있으면 좋을 것 같습니다. 그렇게 될 경우 프로젝트 전반의 모든 queryKey가 있기에 중복을 피할 수 있습니다
| setAllLinks(AllLinks.data.folder); | ||
| } | ||
|
|
||
| const { data: FoldersData } = useQuery({ |
There was a problem hiding this comment.
현재는 하나의 useQuery만 사용하셔서 컴포넌트 내부에 있지만, 저는 해당 부분도 따로 커스텀 훅으로 분리하여 사용하는 편입니다. 추후에 로직 등의 처리를 위해 select옵션 등을 사용하시게 된다면 그 부분을 고려해주셔도 좋을 것 같습니다!
| const router = useRouter(); | ||
| const { folderId } = router.query; | ||
|
|
||
| async function fetchData() { |
There was a problem hiding this comment.
이 부분은 useQuery를 사용해보시면 어떨까요 ?
| }; | ||
|
|
||
| const postSigninMutaion = useMutation({ |
There was a problem hiding this comment.
useMutation 선언은 useState와 비슷하게 컴포넌트 선언내부 상단에서 해주시면 좋을 것 같습니다.
use로 시작하는 hook의 경우 상단에서 모아져 있는 것이 좋습니다
| }; | ||
|
|
||
| const postSignUpMutaion = useMutation({ |
|
|
||
| const toggleHandler = () => { | ||
| setIsOpen(!isOpen); | ||
| }; | ||
|
|
||
| const handleAddFolder = () => { | ||
| postFolderMutation.mutate(inputValue); | ||
| queryClient.invalidateQueries(); |
There was a problem hiding this comment.
invalidateQueries 어떤 쿼리를 무효화할지 특정해주시는게 좋습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
멘토에게