Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
reviewed
Feb 25, 2024
| <body> | ||
| <div class="container"> | ||
| <nav class="nav"> | ||
| <a href="/"><img src="./logo.svg" alt="" class="logo hoverc"></a> |
There was a problem hiding this comment.
img 태그엔 꼭꼭 alt 속성값 채워주세요!
There was a problem hiding this comment.
hoverc 는 hoverclass 라는 뜻일까요? 그렇다면 그냥 hover 라고만 쓰셔도 될 거 같습니다!
| </div> | ||
| <main> | ||
| <div class="sec one"> | ||
| <div class="sec one body"> |
There was a problem hiding this comment.
classname 을 one, two 처럼 짓는 것은 지양해주세요! 어떤 기능을 하는가를 기준으로 지으시는 걸 추천드립니다!
그리고 태그명을 대체하는 클래스명(sec, body)도 그냥 태그에 바로 스타일을 먹이시는 걸 추천드립니다!
Comment on lines
+1
to
+23
| :root { | ||
| --gra-purpleblue-to-skyblue: linear-gradient(91deg, #6D6AFE 0.12%, #6AE3FE 101.84%); | ||
| --gra-purpleblue-to-pink: linear-gradient(91deg, #6D6AFE 17.28%, #FF9F9F 74.98%); | ||
| --gra-pink-to-blue: linear-gradient(96deg, #FE8A8A 1.72%, #A4CEFF 74.97%); | ||
| --gra-yello-to-blue:linear-gradient(277deg, #6FBAFF 59.22%, #FFD88B 93.66%); | ||
| --gra-blue-to-blue:linear-gradient(99deg, #6D7CCD 19.76%, rgba(82, 136, 133, 0.22) 52.69%); | ||
| --gra-skyblue-to-blue:linear-gradient(271deg, #FE578F -9.84%, #68E8F9 107.18%); | ||
| --purple-color: #6D6AFE; | ||
| --red-color: #FF5B56; | ||
| --black-color: #111322; | ||
| --white-color: #FFFFFF; | ||
| --gray1-color: #3E3E43; | ||
| --gray2-color: #9FA6B2; | ||
| --gray3-color: #CCD5E3; | ||
| --gray4-color: #E7EFFB; | ||
| --gray5-color: #F0F6FF; | ||
| --gray6-color: #6B6B6B; | ||
| } | ||
|
|
||
| *{ | ||
| box-sizing: border-box; | ||
| } | ||
|
|
There was a problem hiding this comment.
공통되는 스타일들은 한 번만 정의하고 다른 곳에서 가져오는 식으로 짜시는 걸 추천드립니다!
| </main> | ||
| </div> | ||
| <footer> | ||
| <div class="footcontainer"> |
There was a problem hiding this comment.
따로 ~container 로 묶지 않으시고 바로 시맨틱 태그에 클래스명 적고 스타일 주셔도 좋을 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게