Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
devToram
approved these changes
May 31, 2024
Comment on lines
30
to
34
| interface ItemsProps { | ||
| folderData: FetchData<FolderData[]>; | ||
| linkData: FetchData<LinkData[]>; | ||
| folderData?: FetchData<FoldersData>; | ||
| linkData?: FetchData<LinksData>; | ||
| shareLinkData?: FetchData<LinkData[]>; | ||
| } |
There was a problem hiding this comment.
전부 Optional 한 속성이면 Partial<> 써보셔도 좋을 거 같아요~ (의미상으로 맞다면)
https://www.typescriptlang.org/docs/handbook/utility-types.html#partialtype
Comment on lines
+40
to
93
| return ( | ||
| <> | ||
| {!loading && | ||
| error === null && | ||
| (data?.folder.length === 0 ? ( | ||
| <EmptyDiv> | ||
| <EmptySpan>저장된 링크가 없습니다.</EmptySpan> | ||
| </EmptyDiv> | ||
| ) : ( | ||
| data?.folder.map((item) => ( | ||
| <Item | ||
| key={item.id} | ||
| createdAt={item.created_at} | ||
| url={item.url} | ||
| title={item.title} | ||
| description={item.description} | ||
| imageSource={item.image_source} | ||
| folderData={folderData} | ||
| editable={true} | ||
| /> | ||
| )) | ||
| ))} | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| if (shareLinkData) { | ||
| const { data, loading, error } = shareLinkData; | ||
|
|
||
| return ( | ||
| <> | ||
| {!loading && | ||
| error === null && | ||
| (data?.length === 0 ? ( | ||
| <EmptyDiv> | ||
| <EmptySpan>저장된 링크가 없습니다.</EmptySpan> | ||
| </EmptyDiv> | ||
| ) : ( | ||
| data?.map((item) => ( | ||
| <Item | ||
| key={item.id} | ||
| createdAt={item.created_at} | ||
| url={item.url} | ||
| title={item.title} | ||
| description={item.description} | ||
| imageSource={item.image_source} | ||
| editable={false} | ||
| /> | ||
| )) | ||
| ))} | ||
| </> | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
거의 두 개가 동일해서 합치면 좋을 거 같아요!
const givenData = linkData || shareLinkData 한 뒤에 합치면 될 거 같아요~
| loading: folderData.loading, | ||
| error: folderData.error, | ||
| }} | ||
| folderId={folderId ? parseInt(folderId.toString()) : 0} |
There was a problem hiding this comment.
Suggested change
| folderId={folderId ? parseInt(folderId.toString()) : 0} | |
| folderId={folderId ? parseInt(folderId.toString() ,10) : 0} |
parseInt 쓰실 때 왠만하면 인수도 같이 써주셔요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게