Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
reviewed
May 20, 2024
| onBlur?: (param: SyntheticEvent) => void; | ||
| onChange?: (param: SyntheticEvent) => void; | ||
| hasError?: boolean; | ||
| type?: string; | ||
| } |
There was a problem hiding this comment.
기존 Input 태그를 감싸는 방식으로 Props 를 가져오고 싶으시다면 React.InputHTMLAttributes<HTMLInputElement> 를 사용해보셔도 좋을 거 같아요!
| // }, []) | ||
|
|
||
| useEffect(() => { | ||
| if (loading !== true && error === null) { |
There was a problem hiding this comment.
Suggested change
| if (loading !== true && error === null) { | |
| if (!loading && error === null) { |
| if (loading !== true && error === null) { | ||
| if (data.data) { | ||
| localStorage.accessToken = data.data.accessToken; | ||
| router.push('folder'); |
There was a problem hiding this comment.
확실하게 early return 적어주시는 걸 추천드려요!
| }, [data, loading, error]); | ||
|
|
||
| const handleEyeClick = () => { | ||
| setPwType(pwType === 'password' ? 'text' : 'password'); |
There was a problem hiding this comment.
pwType 을 enum 타입으로 정하고 쓰면 좋을 거 같습니다!
enum PW_TYPE = {...}
Comment on lines
+54
to
+82
| const checkDuplicate = async (value: string) => { | ||
| try { | ||
| const res = await fetch(baseUrl + endpoints.checkEmail.url, { | ||
| method: endpoints.checkEmail.method, | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| body: JSON.stringify({ | ||
| email: value.toString(), | ||
| }), | ||
| }); | ||
|
|
||
| if (res.status === 200) { | ||
| return true; | ||
| } | ||
|
|
||
| if (res.status === 409) { | ||
| return '이미 사용 중인 이메일입니다.'; | ||
| } | ||
| } catch (error: unknown) { | ||
| if (error instanceof Error) { | ||
| return error.message; | ||
| } else { | ||
| return 'Unexpected error'; | ||
| } | ||
| } | ||
|
|
||
| return true; | ||
| }; |
There was a problem hiding this comment.
함수가 state 를 쓰는 게 없다면 유틸함수로 빼주셔요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게