Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
reviewed
May 20, 2024
Comment on lines
+65
to
+68
| let url = `${CODEIT_BASE_URL}/users/${userId}/links`; | ||
| if (folderId) { | ||
| url += `?folderId=${folderId}`; | ||
| } |
There was a problem hiding this comment.
삼항연산자를 사용하면 url 을 const 로 쓸 수 있을 거 같아요!
| import styles from "./index.module.css"; | ||
|
|
||
| interface AuthHeaderProps { | ||
| purpose: string; |
There was a problem hiding this comment.
purpose 가 "signin" 아니면 "signup" 등 정해진 문자라서 조금 더 좁은 타입으로 정의해주심 좋을 거 같아요!
type TProps = "signin" | "signup"
| <span>소셜 로그인</span> | ||
| <ul className={styles.socialLoginBtns}> | ||
| {SOCIALLINKS.map(({ src, href }, i: number) => ( | ||
| <li key={i}> |
There was a problem hiding this comment.
key 를 index 로 주면 아예 안 준것과 똑같아서 만약 중복이 없다면 src 자체를 key 로 넘기는 것도 좋을 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
멘토에게