Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const router = useRouter(); | ||
|
|
||
| const handleLogout = () => { | ||
| localStorage.removeItem('accessToken'); |
There was a problem hiding this comment.
스토리지 키값도 상수로 관리하면 어떨까요?
Comment on lines
+44
to
+66
| try { | ||
| const response = await fetch(SIGN_IN_BASE_URL, { | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| body: JSON.stringify({ email, password }), | ||
| }); | ||
|
|
||
| if (!response.ok) { | ||
| throw new Error('로그인에 실패했습니다.'); | ||
| } | ||
| const data = await response.json(); | ||
| const { accessToken, refreshToken } = data; | ||
| localStorage.setItem('accessToken', accessToken); | ||
| localStorage.setItem('refreshToken', refreshToken); | ||
|
|
||
| router.push('/folder'); | ||
| } catch (error) { | ||
| console.error('Error:', error); | ||
| handleIdErrorOnSubmit(); | ||
| handlePWdErrorOnSubmit(); | ||
| } |
There was a problem hiding this comment.
fetch / success / fail 을 나눠서 관리하면 어떨까요?
// api 관련 파일
const signin = async (body: {email: string, password: string}, {successCb, fallCb}?: {successCb: () => void, failCb: () => void}) => {
// ...
}
function handleSubmit() {
signin({email, 토큰 저장, 에러표시});
// 아니면 fetch 함수만 분리하고 try catch 문과 성공 실패는 이 함수에서 처리해도 괜찮을 것 같아요.
}
Comment on lines
+23
to
+30
| const { | ||
| email, | ||
| isIdError, | ||
| idErrorMsg, | ||
| handleEmailChange, | ||
| handleIdBlur, | ||
| handleIdErrorOnSubmit, | ||
| } = useSignInId(); |
There was a problem hiding this comment.
커스텀 훅으로 관심사를 분리한 부분 좋습니다 👍
Comment on lines
+4
to
+11
| export interface InputProps { | ||
| value: string; | ||
| onChange: (value: string) => void; | ||
| placeholder: string; | ||
| isError: boolean; | ||
| ErrorMsg: string; | ||
| onBlur: () => void; | ||
| } |
There was a problem hiding this comment.
id, password input 에서 공통으로 사용된다면 외부 파일에 추가해서 관리하는게 좋을 것 같습니다.
There was a problem hiding this comment.
이번에 styled component 에서 module css 로 스타일링 방식을 변경하신 것 같네요!
이유가 있으신가요?
o-seung-yeon
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
https://5-weekly-mission-jjs-byukchongs-projects.vercel.app/
멘토에게