Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
reviewed
Feb 24, 2024
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width= , initial-scale=1.0" /> |
There was a problem hiding this comment.
width 를 쓰신다면 숫자를, 안쓰신다면 제거해주세요~
| </div> | ||
| </section> | ||
|
|
||
| <section class="section manage"> |
There was a problem hiding this comment.
클래스 이름으로 태그 이름을 쓰시는 건 지양해주세요! 실제 하는 역할을 나타내는 클래스 이름을 추천드립니다!
| --Gray5: #f0f6ff; | ||
| --Gray6: #6b6b6b; | ||
| --Grey-Light: #f5f5f5; | ||
| --gra-purpleblue-to-skyblue: linear-gradient(91deg, #6d6afe 0.12%, #6ae3fe 101.84%); |
There was a problem hiding this comment.
css변수 규칙이 있으면 좋을 거 같아요 다 대문자로 시작하는데 , gra~ 변수만 소문자로 시작하네요!
| padding: 16px 20px; | ||
| border-radius: 8px; | ||
| border-radius: 8px; | ||
| text-decoration: none; |
Comment on lines
+23
to
+24
| text-decoration: none; | ||
| text-align: center; |
There was a problem hiding this comment.
이런 속성은 아마 figma에서 그대로 따오신 거 같은데, 피그마는 진짜 참고이고, 실제로 사용하는 최소한의 속성만 기재해주세요!
| } | ||
|
|
||
| .move-link p { | ||
| color: var(--black, #000); |
There was a problem hiding this comment.
기존 변수는 --Black 이었던 거 같아요!
| } | ||
|
|
||
| .social-login p { | ||
| color: var(--Linkbrary-gray100, #373740); |
There was a problem hiding this comment.
이미 지정해놓은 css 변수에 대해서는 대체 컬러를 지정하지 않아도 될 거 같아요!
kiJu2
pushed a commit
that referenced
this pull request
Mar 19, 2024
style: sign-in 오류 시 input style에 red border 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게