Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-WKJun
reviewed
May 10, 2024
There was a problem hiding this comment.
craco를 잘 사용해주고 계시는 군요 Very good 입니다. 👍
Comment on lines
+10
to
+13
| "@types/jest": "^27.5.2", | ||
| "@types/node": "^16.18.96", | ||
| "@types/react": "^18.3.1", | ||
| "@types/react-dom": "^18.3.0", |
There was a problem hiding this comment.
type이나 typescript같은 것은 build된 App 결과물에 필요없는 dependency입니다.
App 구동에 관여하지 않는 dependency들은 모두 devDependency에 정리해주세요.
| import instagramLogo from '@assets/images/instagram_logo.svg'; | ||
| import styles from './Footer.module.css'; | ||
|
|
||
| const Footer = forwardRef<any, any>((props, ref) => { |
There was a problem hiding this comment.
forwardRef의 Generic type에도 type을 지정해보는게 어떨까요!
좋은 경험이 될 겁니다.
Comment on lines
+14
to
+16
| interface UserInfo { | ||
| [key: string]: any; | ||
| } |
There was a problem hiding this comment.
보통 UserInfo의 interface는 strict하게 정해져있을 거라고 생각되는데 어떻게 생각하시나요?
key가 그냥 string이면 일반 object와 다르지 않습니다.
any와도 같은 object선언은 최대한 지양해주세요.
|
|
||
| function noop() {} | ||
|
|
||
| const SHARE_BUTTONS_INFO: { [key: string]: ShareButtonProps } = { |
There was a problem hiding this comment.
타입 추론이 되는 상황에선 타입 단언은 불필요합니다. 오히려 혼란만 일으킵니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
배포 링크 : https://bk-part2.netlify.app
기본
심화
주요 변경사항
스크린샷
멘토에게