Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devym-37
approved these changes
May 6, 2024
| <img src={TwitterLogo} alt="twitter-logo" /> | ||
| <img src={YoutubeLogo} alt="youtube-logo" /> | ||
| <img src={InstagramLogo} alt="instagram-logo" /> | ||
| {footerLogoList.map((item) => ( |
There was a problem hiding this comment.
footerLogoList를 외부에서 관리하시는 것은 좋은 것 같습니다
| import youtubeIcon from "../../assets/youtube.svg"; | ||
| import instagramIcon from "../../assets/instagram.svg"; | ||
|
|
||
| const footerLogoList = [ |
|
|
||
| const cx = classNames.bind(styles); | ||
|
|
||
| export const Profile = ({ profile }) => { |
There was a problem hiding this comment.
추후에는 해당 컴포넌트에서 필요한 데이터만 props로 받는것으로 수정해주시는 것도 좋을 것 같습니다. ex) email, profileImage 정보만 받는 것 입니다
|
|
||
| export function useAsync(asyncFuction) { | ||
| const [data, setData] = useState(null); | ||
| function useAsync(asyncFuction) { |
| }, []); | ||
|
|
||
| return { data, loading, error }; | ||
| return [loading, error, data, wrappedFunction]; |
There was a problem hiding this comment.
return 타입을 {} 객체에서 [] 배열 상태로 바꾸신 이유가 있으실까요 ?
| <button>삭제</button> | ||
| </div> | ||
| ) : ( | ||
| "" |
There was a problem hiding this comment.
"" 보다는 null로 해주시는 것이 좋을 것 같습니다
| src={noImageLogo} | ||
| alt="카드 썸네일 없음" | ||
| /> | ||
| )} |
There was a problem hiding this comment.
img 태그 하나만을 사용하고, 값 등에 삼항연산자를 사용하셔도 될 것 같습니다.
ex) src={item.image_source ? item.image_source : noImageLogo} 입니다
| @@ -0,0 +1,38 @@ | |||
| import { TIME } from "./constant"; | |||
|
|
|||
| export const getElapsedTime = (createdAt) => { | |||
There was a problem hiding this comment.
util 폴더 하위에 파일로 분리해주신 부분 잘해주신 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게