[이현승] week12 #373
Merged
[이현승] week12 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13akstjq
reviewed
May 6, 2024
| } | ||
| `; | ||
|
|
||
| const AddLink = ({ folder, footView }: { folder: any; footView: boolean }) => { |
| } | ||
| `; | ||
|
|
||
| const AddLink = ({ folder, footView }: { folder: any; footView: boolean }) => { |
There was a problem hiding this comment.
이런 방식으로 작성하면 가독성이 더 좋을 것 같습니다
Suggested change
| const AddLink = ({ folder, footView }: { folder: any; footView: boolean }) => { | |
| interface AddLinkPrpos { | |
| folder: any; | |
| footView: boolean; | |
| } | |
| const AddLink = ({ folder, footView }: AddLinkProps) => { |
| }; | ||
|
|
||
| const handleSearch = (e: ChangeEvent<HTMLInputElement>) => { | ||
| if (search?.current?.value !== "") { |
There was a problem hiding this comment.
타입스크립트가 동작하는 방식 중 이런 경우가 타입 좁히기랍니다. 내용 참고해보세요!
https://ahnheejong.gitbook.io/ts-for-jsdev/06-type-system-deepdive/type-narrowing
|
|
||
| interface Props { | ||
| selectFolder: (e: MouseEvent<any, MouseEvent>) => void; | ||
| folderInfo: any; |
|
파트2 진행하시느라 고생 많으셨습니다 현승님! 멘토링 때 참여도 가장 활발히 해주시고, 코드도 너무 잘 작성해주시는 모습 보여주셔서 좋았습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게