Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-WKJun
approved these changes
Apr 29, 2024
| <button className="link-button">추가하기</button> | ||
| </div> | ||
| </form> | ||
| const { openModal, setModalType } = useContext(ModalContext); |
There was a problem hiding this comment.
useContext(ModalContext);이 코드가 반복되고 있네요 해결방법이 없을까요?
There was a problem hiding this comment.
이건 useToggle이랑 다른 점이 없는 것 같네요.
There was a problem hiding this comment.
Folder에 일반 JSX도 있고 Context도 있고 굉장히 많은 것들이 혼재해 있네요.
맥락에 따라 코드를 더 나눠보면 좋을 것 같습니다.
| @@ -43,11 +48,16 @@ export const tabDataList = async () => { | |||
|
|
|||
| export const userFoldersData = async () => { | |||
| try { | |||
| const response = await fetch(`${BASE_URL}api/users/1/links`); | |||
| if (!response.ok) { | |||
| const response = await axios.get(`${BASE_URL}api/users/1/links`); | |||
There was a problem hiding this comment.
axios.get(`${BASE_URL}api/users/1/links코드가 반복되는 것 같습니다.
Comment on lines
+12
to
+17
| <li> | ||
| <button> | ||
| <img src={KakaoIco} alt="카카오톡 공유하기" /> | ||
| <h3>카카오톡</h3> | ||
| </button> | ||
| </li> |
There was a problem hiding this comment.
modalType 판단과 더불어, 무엇을 그려야하는지 jsx가 그대로 노출 돼 있어 가독성과 유지보수성이 떨어집니다.
좀 더 리팩토링 해볼 여지가 있을 것 같습니다.
Comment on lines
+12
to
+37
| const cardTitleIcon = [ | ||
| { | ||
| url: shareIcon, | ||
| text: "공유", | ||
| url: shareIcon, | ||
| text: "공유", | ||
| onClick: () => { | ||
| setModalType("share"); | ||
| openModal(); | ||
| }, | ||
| }, | ||
| { | ||
| url: penIcon, | ||
| text: "이름 변경", | ||
| url: penIcon, | ||
| text: "이름 변경", | ||
| onClick: () => { | ||
| setModalType("edit"); | ||
| openModal(); | ||
| }, | ||
| }, | ||
| { | ||
| url: deleteIcon, | ||
| text: "삭제", | ||
| url: deleteIcon, | ||
| text: "삭제", | ||
| onClick: () => { | ||
| setModalType("folderDelete"); | ||
| openModal(); | ||
| }, | ||
| }, | ||
| ]; | ||
| ]; |
There was a problem hiding this comment.
상수는 컴포넌트안에서 선언하지 않는 것이 좋습니다.
컴포넌트의 특성과 변수 생성 규칙을 생각해보면 그 이유를 알 수 있습니다.
Jay-WKJun
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
스크린샷
멘토에게