Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-WKJun
approved these changes
Apr 29, 2024
| return ( | ||
| <button onClick={onClick} className={styles.btn}> | ||
| <button onClick={onClick} className={`${className} ${styles.btn}`}> |
There was a problem hiding this comment.
매번 백틱과 ${}를 열어서 하나씩 조합하는 건 굉장히 귀찮을 일일 것입니다.
이걸 해결할 수 있는 방법을 고민해보면 좋을 것 같습니다.
Comment on lines
+24
to
+47
| const UTIL_BUTTONS_PROPS = [ | ||
| { | ||
| imgSrc: shareIcon, | ||
| btnText: '공유', | ||
| alt: '공유 아이콘', | ||
| id: 1, | ||
| onClick: onShare, | ||
| }, | ||
|
|
||
| { | ||
| imgSrc: penIcon, | ||
| btnText: '이름 변경', | ||
| alt: '이름 변경 아이콘', | ||
| id: 2, | ||
| onClick: onFolderNameChangeClick, | ||
| }, | ||
| { | ||
| imgSrc: deleteIcon, | ||
| btnText: '삭제', | ||
| alt: '삭제 아이콘', | ||
| id: 3, | ||
| onClick: onFolderDeleteClick, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
컴포넌트 안에 이런 고정 constant를 넣어두면 안됩니다.
컴포넌트의 특징과 그 내부의 변수가 어떻게 생성되는지 알아보시면 좋을 것 같습니다.
Comment on lines
+36
to
+39
| const DROPDOWN_LIST_ITEMS = [ | ||
| { text: '삭제하기', onClick: handleLinkDelete }, | ||
| { text: '폴더에추가', onClick: handleAddToFolder }, | ||
| ]; |
There was a problem hiding this comment.
위와 동일하게 상수값은 컴포넌트가 아닌 다른 곳에서 선언해주는 것이 좋습니다.
| <div className={styles.modalContainer}> | ||
| <div className={styles.modalWrapper}> | ||
| <button onClick={onClose} className={styles.closeButton}></button> | ||
| {children} |
| </div> | ||
| <ul className={styles.folderList}> | ||
| {curFolders.map((folder) => ( | ||
| <li> |
There was a problem hiding this comment.
map으로 생성되는 component는 key값을 꼭 지정해주시는 편이 좋습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
스크린샷
멘토에게