Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
수고 하셨습니다 ! 위클리 미션 하시느라 정말 수고 많으셨어요. |
이번주 전날 전달받은 가족행사로 완성하지 못하였습니다. 다음주에 피드백과 함께 같이 반영하도록 하겠습니다.넵넵 ! 좋습니다 유민님 ㅎㅎㅎ |
kiJu2
approved these changes
May 1, 2024
| onChange, | ||
| }) => { | ||
| return ( | ||
| <Modal isOpen={isOpen} onCloseClick={onCloseClick} onKeyDown={onKeyDown}> |
| import * as S from "./ModalContentBox.style"; | ||
| import { CLOSE_IMAGE } from "./constant"; | ||
|
|
||
| export const ModalContentBox = ({ title, content, onCloseClick }) => { |
There was a problem hiding this comment.
이건 Modal.jsx 안에 같이 있어도 되지 않을까요?
Modal 컴포넌트를 쓰면 함께 사용하는 친구로 보여서요 !
There was a problem hiding this comment.
(제안)또한, 네이밍은 ModalBody로 작성해도 될 것 같습니다 !
|
|
||
| import * as S from "./Modals.style"; | ||
|
|
||
| export const AddLinkModal = ({ |
There was a problem hiding this comment.
Modal을 합성하여 새로운 목적의 컴포넌트들을 작성하셨군요 ! 👍
| placeholder, | ||
| description, | ||
| buttonText, | ||
| onCloseClick, |
There was a problem hiding this comment.
onCloseClick은 Click이라는 행위가 들어가있습니다.
onClose라는 워딩만 사용해도 어떨까 싶어요. onClose가 되는 이벤트에만 목적을 두는 핸들러가 어떨까해서 제안드립니당 !
| setIsModalOpen(false); | ||
| }; | ||
|
|
||
| const handleKeyDown = (event) => { |
There was a problem hiding this comment.
센스가 좋네요 ㅎㅎㅎ ESC를 눌러서 닫히는 것은 좋은 사용자 경험이죠.
| @@ -0,0 +1,28 @@ | |||
| import styled from "styled-components"; | |||
| import { useEffect, useState } from "react"; | ||
| import { createPortal } from "react-dom"; | ||
|
|
||
| export const Portal = ({ children }) => { |
There was a problem hiding this comment.
포탈로 모달을 만드셨군요 ! 👍👍
훌륭합니다 ! 포탈 컴포넌트를 따로 만들어본 적은 없는데 이렇게 분리시킬 수도 있겠군요.
|
오우 ! 유민님 이번 코드 너무 좋은데요? 팀 미션 수행하고 해이해질 수도 있었을텐데 끝까지 잘 해내셨군요 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
-> "폴더 이름 변경", "폴더 추가", "폴더 삭제", "폴더에 추가" 모달 완료
주요 변경사항
스크린샷
멘토에게