Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13akstjq
reviewed
Apr 28, 2024
| }, []); | ||
|
|
||
| return ( | ||
| <Modal> |
There was a problem hiding this comment.
Modal 컴포넌트를 만들어서 children으로 컨텐츠를 받아서 작업하신 것 잘하셨습니다!
| {deleteFolder && ( | ||
| <ModalDeleteFolder info={selectedFolder?.name} onClick={handleDel} /> | ||
| )} | ||
| {nameChange && <ModalEdit onClick={handleChange} />} |
There was a problem hiding this comment.
onClick props 보다는 onCloseButtonClick 이 더 명확할 것 같습니다~!
| `; | ||
|
|
||
| const ModalFrame = ({ children, name, onClick }) => { | ||
| useEffect(() => { |
There was a problem hiding this comment.
스크롤 유지한채로 스크롤 잘 막아주셨네요!👍
| const [selectedFolder, setSelectedFolder] = useState(null); | ||
|
|
||
| const selectFolder = (e) => { | ||
| const folderId = Number(e.target.name); |
There was a problem hiding this comment.
typeof 를 통해서도 처리할 수 있을 것 같습니다~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
없음
주요 변경사항
스크린샷
멘토에게