Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Fix] delete merged branch github action
[조혜진] Week2
[조혜진] Week3
[조혜진] Week4
13akstjq
reviewed
Apr 1, 2024
| @@ -0,0 +1,26 @@ | |||
| // Article.js | |||
| import { useFetch } from './hooks/useFetch'; | |||
| @@ -0,0 +1,26 @@ | |||
| // Article.js | |||
| import { useFetch } from './hooks/useFetch'; | |||
| import '../style.css'; | |||
There was a problem hiding this comment.
style.css에서 모든 css를 작성하기 보다는 컴포넌트별로 css 파일을 작성하는 것이 좋습니다.
react의 css module에 대해서 알아보시면 컴포넌트 별 스타일을 작성하시는데 도움이 되실거에요!
| const folderData = useFetch('https://bootcamp-api.codeit.kr/api/sample/folder'); | ||
|
|
||
| // 날짜 형식 변경 함수 | ||
| const formatDate = (dateString) => { |
There was a problem hiding this comment.
날짜 형식에 대한 함수는 공통으로 사용될 수 있으니 utils 폴더를 만들어 작성하면 좋을 것 같습니다~!
| // Cards.js | ||
| import { useFetch } from '../hooks/useFetch'; | ||
| import { Link } from 'react-router-dom'; | ||
| import moment from 'moment'; |
| const months = Math.floor(timeDiff / (60 * 24 * 30)); | ||
| return months === 1 ? '1 month ago' : `${months} months ago`; | ||
| } | ||
| const years = Math.floor(timeDiff / (60 * 24 * 30 * 12)); |
There was a problem hiding this comment.
60, 24, 30, 12 는 상수로 작성해서 사용하면 더 알기 쉬울 것 같습니다!
| {generateTimeText(link.createdAt)} | ||
| </p> | ||
| </div> | ||
| <div className="card_txt_div_body"> |
There was a problem hiding this comment.
여기도 굳이 p태그를 감싸야할 이유가 있으신가요??
불필요한 태그 중첩은 가독성이 오히려 떨어지기 때문에 필요한 요소만 작성해주시는 것이 좋습니다!
| return ( | ||
| <header className="navbar"> | ||
| <Link to="/" className="logo"> | ||
| <img src={logo} width="133" height="24" alt="logo" /> |
There was a problem hiding this comment.
logo 보다는 "Linkbrary" 텍스트를 넣어주는 것이 접근성 측면에서 더 좋겠죠??
이 내용도 멘토링 시간에 얘기나눌게요!
| // useFetch.js | ||
| import { useState, useEffect } from 'react'; | ||
|
|
||
| export function useFetch(url) { |
| import '../style.css'; | ||
|
|
||
| function Article() { | ||
| const folderData = useFetch('https://bootcamp-api.codeit.kr/api/sample/folder'); |
There was a problem hiding this comment.
baseurl 을 constants 폴더를 만들어 상수로 분리해서 사용하면 좋을 것 같습니다!
| <link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" /> | ||
| <link rel="manifest" href="%PUBLIC_URL%/manifest.json" /> | ||
| <title>Linkbrary</title> | ||
| `````` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게