-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[정용준] Week13 #399
The head ref may contain hidden characters: "part3-\uC815\uC6A9\uC900-week13"
[정용준] Week13 #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
용준님 너무 깔끔해졌습니다 코드가, 저도 좀 더 보고 코멘트 추가적으로 있으면 남겨둘게요!
@@ -0,0 +1,16 @@ | |||
import { postSignin, postSignup } from "@/apis/auth/auth"; | |||
|
|||
export const resolvers = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolver 라는 이름이 내포하고 있는 의미가 뭘까요? 약간은 어색해보여서요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://blog.neonkid.xyz/238
스프링에서 파라미터를 가공해서 데이터를 뽑아내는 객체를 resolver라고 하길래 똑같이 네이밍을 해봤습니다. 음..Mapper가 더 직관적일까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음... mapper 나 resolve 둘 다 의미가 명확히 전달되지는 않는 것 같아요 ㅋㅋ
값을 뽑아내서 토큰을 저장하는 거니까.. 흠.....
오히려 controller 가 더 어울리는 것 같기도 하고...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뷰에 도착하기 전까지의 플로우만 정의한다면 Controller가 더 어울리는 이름 같습니다. 값을 뽑아내서 뷰 모델에 맞게 바꾸는건
Resolver 혹은 Adapter, 플로우만 명시하고 각각의 동작들은 함수로 빼거나 다른 객체에게 위임을 하는 건 Controller 어떨까요?
요구사항
기본
회원가입을 실행할 경우, 문제가 있는 경우 문제가 있는 input에 에러 메세지로 알립니다.
심화
주요 변경사항
스크린샷
멘토에게