Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoon-kyungLee
added
매운맛🔥
jlstgt
approved these changes
Jan 10, 2024
| const [inputType, setInputType] = useState(type); | ||
| const [isError, setIsError] = useState<boolean>(false); | ||
|
|
||
| const togglePasswordVisibility = (e: React.MouseEvent<HTMLButtonElement>) => { |
| errorMessage?: string; | ||
| } | ||
|
|
||
| function AuthInput({ label, type, placeholder, onValid, errorMessage }: AuthInputProps) { |
There was a problem hiding this comment.
저번에 말씀드린 대로 실제 <input>은 더 많은 attribute가 있으므로 나머지 모든 prop을 ...rest 등으로 받아서 <input>에 적용해주시면 좋을 것 같습니다.
| label: string; | ||
| type: "text" | "email" | "password"; | ||
| placeholder?: string; | ||
| onValid?: () => boolean; |
There was a problem hiding this comment.
onValid로 onBlur의 역할을 구현하신 것 같은데, 이 이름은 onValid 보다는 onBlur 같은 게 되는 것이 더 적절해 보입니다. Validation check를 수행하는 건 Blur가 되었을 때 일어나는 여러 일 중에 하나이기 때문입니다.
| /> | ||
| {type === "password" && ( | ||
| <button className={styles.eyeButton} onClick={togglePasswordVisibility}> | ||
| <Image |
| return ( | ||
| <nav className={styles.nav}> | ||
| <div className={styles.navContainer}> | ||
| <Link href="/"> |
| } | ||
|
|
||
| function AuthInput({ label, type, placeholder, onValid, errorMessage }: AuthInputProps) { | ||
| const [inputType, setInputType] = useState(type); |
There was a problem hiding this comment.
prop으로 받아온 값을 state의 초기값으로 지정하신 것 같네요. 잘 구현해주셨습니다.
jlstgt
reviewed
Jan 10, 2024
| /> | ||
| </button> | ||
| )} | ||
| {isError && <p className={styles.errorMessage}>{errorMessage}</p>} |
There was a problem hiding this comment.
더 정확히 하려면 isError && errorMessage && <p ...가 되어야 될 것 같습니다. errorMessage가 없으면 p 요소 자체가 생성이 안 되면 더 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
멘토에게
매운맛을 바라지만 또 순한맛을 바라고.... 제 코드만큼 혼란스럽군여..(커밋도 차근차근 수정하지 못하다 보니 커밋도 까먹어버렸네요,, 호호 )