-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[안소연] week12 #350
Merged
domuk-k
merged 17 commits into
codeit-bootcamp-frontend:part3-안소연
from
sozign:part3-안소연-week12
Jan 13, 2024
The head ref may contain hidden characters: "part3-\uC548\uC18C\uC5F0-week12"
Merged
[안소연] week12 #350
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8320c85
feat: next/ts 마이그레이션
3e0226f
feat: 레이아웃이 페이지 세로 영역 꽉채우게
1b52fb4
feat: 링크 데이터 형식 통일
ae8ae4c
refactor: api 데이터 타입지정
1579e0d
feat: img src 임포트 경로 수정
f4ac0de
feat: signup 페이지 제작
10f18cc
feat:signin 기능 구현
22d86e5
feat: accessToken 가진 사용자라면 '/folder'로 redirect
2a55d2b
feat: gnb, footer _app.tsx(공통레이아웃)에서 삭제
7165e64
feat: 타입스크립트 전환 완료
f1b8188
style: api 폴더 위치 변경
a353214
refactor(js to ts): ts 변경 완료
e2cf3d8
refactor(review): SearchBar로의 의미없는 prop 전달 삭제
2e22279
refactor(review): css className 컨벤션 통일
5791572
refactor(review): filter 함수 utils 함수로분리
c75a31e
refactor(review): Star 컴포넌트명 및 state명 기능중심적으로 변경
2025ea7
refactor: modal 컴포넌트 최상단 엘리먼트로 렌더링 (create portal)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,43 @@ | ||
{ | ||
"extends": "next/core-web-vitals" | ||
"root": true, // ESLint가 프로젝트의 상위 디렉토리에서 설정 파일을 찾지 않도록 하는 옵션 | ||
"env": { | ||
//프로젝트에서 사용되는 환경을 정의합니다. 여기서는 브라우저, ECMAScript 2020, 그리고 Node.js 환경에서 코드를 실행하는 것으로 설정 | ||
"browser": true, | ||
"es2020": true, | ||
"node": true | ||
}, | ||
"extends": [ | ||
//다양한 ESLint 규칙 세트를 확장하는데 사용 | ||
"next/core-web-vitals", | ||
"eslint:recommended", //ESLint에서 기본으로 권장하는 규칙들을 포함, | ||
"plugin:@typescript-eslint/eslint-recommended" | ||
], | ||
"parserOptions": { | ||
//코드를 파싱하는 데 사용되는 옵션을 설정 | ||
"ecmaVersion": "latest", | ||
"sourceType": "module" | ||
}, | ||
"settings": { | ||
"react": { | ||
"version": "18.2" | ||
} | ||
}, | ||
// ESLint에서 무시할 파일 또는 디렉토리 패턴을 지정합니다. | ||
// 여기서는 .next 디렉토리를 무시하도록 설정 | ||
"ignorePatterns": [".next"], | ||
|
||
"plugins": ["react-refresh", "simple-import-sort", "@typescript-eslint"], | ||
"rules": { | ||
//코드 검사 규칙을 지정 | ||
"no-unused-vars": "off", | ||
"react-refresh/only-export-components": [ | ||
"warn", //아래 규칙에 위배되었을 때 경고를 출력 | ||
{ | ||
"allowConstantExport": true | ||
} | ||
], | ||
"simple-import-sort/imports": "error", //import 구문을 알파벳순으로 정렬하도록 하는 규칙 | ||
"simple-import-sort/exports": "error", //export 구문을 알파벳순으로 정렬하도록 하는 규칙, | ||
"@typescript-eslint/no-unused-vars": "error" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
// 파일을 저장할 때마다 `eslint` 규칙에 따라 자동으로 코드를 수정 | ||
sozign marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"editor.codeActionsOnSave": { | ||
"source.fixAll.eslint": "explicit" | ||
}, | ||
// `prettier`를 기본 포맷터로 지정 | ||
"editor.defaultFormatter": "esbenp.prettier-vscode", | ||
// 파일을 저장할 때마다 포매팅 실행 | ||
"editor.formatOnSave": true, | ||
|
||
//상대 경로 비선호 | ||
"javascript.preferences.importModuleSpecifier": "non-relative" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 node에서도 실행가능한가보군요? 사실 Nextjs에서는 컴포넌트 별로, 또는 특정 위치의 함수의 경우에 server/ client 한 곳에서만 동작하게 의도되기도해서, 이렇게 eslint설정으로 드러낼 필요는 없어 보여요. 혹시 특정 코드에서, 특정 런타임 환경이 제공하는 host 객체를 사용해서 이 처리가 필요했던 걸까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이전 프로젝트 때 사용했던 세팅 코드를 가져온 건데 미처 뜻을 알지 못하고 사용한 부분들이 있습니다.. 😅 이참에 공부해봐야겠네욥