Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat&stlye: AddLink 컴포넌트 생성 및 input css 구현
Tanney-102
reviewed
Dec 26, 2023
There was a problem hiding this comment.
fetcn 함수를 호출하고 response.json을 반환하는 로직이 반복되는 것 같은데 반복되는 부분만 별도의 함수로 분리해보면 어떨가요?
Comment on lines
+7
to
+10
| function formatDate(value) { | ||
| const date = new Date(value); | ||
| return `${date.getFullYear()}. ${date.getMonth() + 1}. ${date.getDate()}`; | ||
| } |
There was a problem hiding this comment.
Date객체의 toLocaleString이나 Intl.DateTimeFormat 같은 아이들로도 어느정도 포맷팅은 가능합니다! 위 formatDate함수에서 하는 일은 해당 api로 불가한 포맷팅일까요?
Comment on lines
+13
to
+18
| const [modalOpen, setModalOpen] = useState(Array(data).fill(false)); | ||
| const showModal = (index) => { | ||
| const newModalOpen = [...modalOpen]; | ||
| newModalOpen[index] = !newModalOpen[index]; | ||
| setModalOpen(newModalOpen); | ||
| } |
There was a problem hiding this comment.
배열도 좋지만 Set을 사용해도 좋겠습니다.
모달마다 id를 주고 그 id를 set에 add/delete하는 방식도 고려해보시면 좋을 것 같아요
Comment on lines
+7
to
+11
| function formatDate(value) { | ||
| const date = new Date(value); | ||
| return `${date.getFullYear()}. ${date.getMonth() + 1}. ${date.getDate()}`; | ||
| } | ||
|
|
There was a problem hiding this comment.
같은 로직이 다른 파일에도 있었던 것 같아요. 별도의 모듈(utils)로 분리하면 좋겠습니다.
|
|
||
| const getProfile = async () => { | ||
| const { data } = await getUser(); | ||
| const { email, image_source } = data[0]; // 인덱스로 접근하는 것 말고 다른 방법이 있을까요? |
There was a problem hiding this comment.
data를 생성하는 시점(클라에서 생성할 수도 있고 서버에서 가져오는 시점을 수 있겠죠?)에 객체 형태로 만들어 주시면 될 것 같아요!
만약 서버에서 배열이 오는 상황이라면
const data = dataFromServer.reduce((acc, cur) => ({
...acc,
[cur.id]: cur
}), {})이런 느낌으로 해볼 수 있을 것 같아요
Tanney-102
merged commit b72c3e0
into
codeit-bootcamp-frontend:part2-박준성
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게