Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaeSang1998
reviewed
Aug 28, 2024
| <p class="section_content_p2">인기 상품을<br> 확인해보세요</p> | ||
| <p class="section_content_p3">가장 HOT한 중고거래 물품을<br> 판다 마켓에서 확인해보세요</p> | ||
| <img class="section-content" src="images/Img_home_01.png" alt="Hot item 그림"> | ||
| <div class="section-content-p-box"> |
There was a problem hiding this comment.
kebab-case 로 잘 변경해주셨군요! 좋습니다.
| @@ -84,25 +85,25 @@ | |||
| @codeit - 2024 | |||
| </div> | |||
| <div class="footer-kid2"> | |||
| <a class="footer-kid-a cursor_pointer" href="privacy.html"> | |||
| <a class="footer-kid-a cursor-pointer" href="/privacy"> | |||
There was a problem hiding this comment.
오 이것도 반영 잘해주셨군요 너무 좋습니다 :)
| Privacy Policy | ||
| </a> | ||
| <a class="footer-kid-a cursor_pointer" href="faq.html"> | ||
| <a class="footer-kid-a cursor-pointer" href="/FAQ"> |
There was a problem hiding this comment.
폴더 이름은 소문자로 해주셔도 좋습니다!
| <link | ||
| rel="stylesheet" | ||
| as="style" | ||
| crossorigin | ||
| href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css" | ||
| /> | ||
| <link rel="stylesheet" href="styles/global.css" /> | ||
| <link rel="stylesheet" href="../styles/home.css" /> |
| @@ -0,0 +1,19 @@ | |||
| :root { | |||
There was a problem hiding this comment.
오 이것도 잘 반영해주셨네요~ 좋습니다! 이렇게 분리해서 사용하는 습관 좋습니다.
| } | ||
|
|
||
|
|
||
| @media (min-width: 375px) and (max-width: 766px) { |
There was a problem hiding this comment.
미디어 쿼리를 잘 써주셌네요 좋습니다!
반응형이 이런부분이 조금 복잡합니다. 그래도 잘 넣어주셨네요 :)
| padding: 32px 10px; | ||
| } | ||
|
|
||
| .footer-kid1 { |
There was a problem hiding this comment.
kid 보다는 child 가 더 많이 쓰이는 명명입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
공통
PC: 1200px 이상
Tablet: 768px 이상 ~ 1199px 이하
Mobile: 375px 이상 ~ 767px 이하
375px 미만 사이즈의 디자인은 고려하지 않습니다.
랜딩페이지
로그인, 회원가입 페이지 공통
심화
주요 변경사항
스크린샷
멘토에게