Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 23, 2024 10:41
- Remove the use of 62.5% font-size to avoid potential issues with inconsistent scaling across different browsers - Use the default font-size instead to provide more predicable behavior
- Adjusted the placement of image elements to imporve layout and user experience
JaeSang1998
reviewed
Aug 28, 2024
| @@ -2,27 +2,29 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| align-items: center; | |||
| gap: 4rem; | |||
| padding: 6rem 0; | |||
There was a problem hiding this comment.
rem 에서 px 로 일부 변경하셨군요 좋습니다 :)
| height: 20px; | ||
| } | ||
|
|
||
| @media screen and (min-width: 768px) { |
There was a problem hiding this comment.
반응형 설계가 굉장히 빡세죠 ㅎㅎ... 하나하나 다 넣어줘야하고, 아주 깜끔하게 잘 넣어주신것 같습니다.
| line-height: 3.5rem; | ||
| } | ||
|
|
||
| .banner-container > .intro > a { |
There was a problem hiding this comment.
이렇게 셀럭터를 통해 부모를 제한하는것도 좋은 방법이긴 하나 저는 이 깊이가 2개가 넘어가는건 경계하는 편입니다.
아무래도 css 는 대형화가 되면서 복잡해질 가능성이 높고, 이렇게 css 를 만들면 추후에 모듈화를 고려할때 머리아픈 경우가 많아서 너무 깊어지지 않도록 주의해주시면 좋을 것 같아요!
| <div class="card-container card-right"> | ||
| <div class="card-content"> | ||
| <div class="card-img card-img3"></div> | ||
| <div class="card-img img"></div> |
There was a problem hiding this comment.
만약 여기에 img classname 이 지속적으로 반복되어야하고 모든 이미지에 반영되어야한다면 root 에 넣어서 전체 반영되게 하는건 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
공통
PC: 1200px 이상
Tablet: 768px 이상 ~ 1199px 이하
Mobile: 375px 이상 ~ 767px 이하
375px 미만 사이즈의 디자인은 고려하지 않습니다
랜딩페이지
로그인, 회원가입 페이지 공통
심화
주요 변경사항
스크린샷
배포 페이지 메인
로그인
회원가입
모바일(랜딩)
태블릿(랜딩)
모바일(로그인)
모바일(회원가입)
멘토에게