Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GANGYIKIM
approved these changes
Aug 19, 2024
| <br />쉽게 찾아보세요 | ||
| </p> | ||
| </div> | ||
| <img src="img/feature2-image.png" alt="검색 기능" width="50%" /> |
There was a problem hiding this comment.
P3:
나중에 반응형 처리하시려면 css 로 이미지 사이즈 컨트롤하시는게 더 좋습니다.
| </div> | ||
| </div> | ||
| <div id="features" class="wrapper"> | ||
| <ul style="list-style-type: none"> |
There was a problem hiding this comment.
P2:
인라인 스타일링보다 css파일에 작성하시는거 추천드립니다.
Suggested change
| <ul style="list-style-type: none"> | |
| <ul> |
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>판다마켓 - 회원가입</title> | ||
| <link rel="icon" href="img/favicon.ico" /> |
Comment on lines
+27
to
+28
| <label for="email">이메일</label> | ||
| <input |
There was a problem hiding this comment.
P3:
라벨과 인풋 연결해주신거 좋습니다 👍
Comment on lines
+53
to
+57
| <img | ||
| src="img/hide_input.svg" | ||
| alt="비밀번호 숨김" | ||
| class="toggle-password" | ||
| /> |
There was a problem hiding this comment.
P3:
나중에 버튼으로 작동할거라 button 태그로 작성해주시면 좋겠습니다.
Comment on lines
+77
to
+80
| <button type="submit" class="button pill-button full-width"> | ||
| 회원가입 | ||
| </button> | ||
| </form> |
There was a problem hiding this comment.
P2:
submit type button과 form 태그 같이 써주신 거 좋습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게