-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[오혁재] sprint1 #15
The head ref may contain hidden characters: "Basic-\uC624\uD601\uC7AC"
[오혁재] sprint1 #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혁재님 너무 고생하셨습니다!
align-content: center; | ||
cursor: pointer; | ||
} | ||
.큰틀 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
한글보다는 영어를 사용해주세요~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 영어로 바꿔보겠습니다
height: 540px; | ||
text-align: center; | ||
} | ||
.Frame2610528 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
css 도 좀 더 의미있는 이름으로 지어주세요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 이름도 좀 의미있게 지어볼게요
<a href="/login"><button class="btn_small_48">로그인</button></a> | ||
</div> | ||
</div> | ||
<div class="큰틀"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
각각 div 로 잘 레이아웃을 분리해주셨군요.
다음번엔 div 뿐만 아니라 section 등의 Semantic Tag 를 사용해 보시면 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
한번 section도 사용해보겠습니다
<p id="상품검색txt">구매를 원하는<br>상품을 검색하세요</p> | ||
<p id="물품검색txt">구매하고 싶은 물품은 검색해서<br>쉽게 찾아보세요</p> | ||
</div> | ||
<img id="Img_home_02" src="images/Img_home_02.png"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
절대경로로 이미지를 잘 넣어주셨습니다!
./images 처럼 상대경로로 표현하는 방법도 있으니, 절대 경로, 상대경로의 차이에 대해서 한 번 알아보셔도 좋을 것 같아요!
position: absolute; | ||
top: 50%; | ||
left: 50%; | ||
margin-left: -343px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
margin 을 minus 를 주신 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
figma에서 이미지 위치가 가운데가 아니라 가운데보다 좀 옆에 있길래 넣어봤습니다..
display: flex; | ||
box-sizing: border-box; | ||
} | ||
#text5 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전체적으로 동일한 피드백인데 text5 보다는 ~~_text 처럼 어떤 텍스트인지 좀 더 이름을 잘 지어주시면 좋습니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵! 의미있는 이름..!
@@ -0,0 +1,279 @@ | |||
html, body { | |||
color: #374151; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color 를 variable 로 설정하는 방법도 한 번 알아보시면 좋을 것 같습니다!
--color-var: #374151
이런식으로 등록하면
var(--color-var) 요렇게 사용할 수 있습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
참고해보겠습니다
요구사항
기본
심화
배포주소
https://endearing-stroopwafel-0f2047.netlify.app
스크린샷
![Group19](images/Property 1=sm.png)
멘토에게