Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[정성현] sprint1 #14

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions README.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md로 문서 정리하시면서 진행하시는 것 너무 좋네요! 👍

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# 🐼 판다마켓

> 일상의 모든 물건을 믿고 거래할 수 있는 **중고 거래 플랫폼**

- [판다마켓 바로가기](https://pandamarket-jsh-git.netlify.app/)
- 코드잇 스프린트 FE-10 스프린트 미션
- 2024.08.05.(월) ~ 개발 진행 중

<br />

## 기술 스택

- **개발**
- HTML, CSS
- **IDE**
- Visual Studio Code
- **배포**
- Netlify
21 changes: 21 additions & 0 deletions faq.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html lang="ko">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문서 언어 한국어로 지정하신 것 좋습니다. 👍

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="icon" href="/images/logo_icon.png" />
<link rel="apple-touch-icon" href="/images/logo_icon.png" />
<title>판다마켓</title>
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="/init.css" />
<link rel="stylesheet" href="style.css" />
</head>
<body>
<h1>FAQ</h1>
</body>
</html>
Binary file added images/explain_1.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피그마 이미지 Export 하실 때 참고하시면 좋을 것 같아 공유드립니다!

디자인 시안에서 보여지는 이미지 크기보다 크게 나타날 수 있는 경우(ex. 시안은 뷰포트가 1280px 너비로 작업 되어 있으나, 더 넓은 화면에서 이미지가 커질 수 있는 경우) 2~3배 정도로 export하여 사용하시는 걸 추천드립니다.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/explain_2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/explain_3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/logo_icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/logo_lg.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/logo_md.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/logo_sm.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/panda_1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/panda_2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
94 changes: 94 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="icon" href="/images/logo_icon.png" />
<link rel="apple-touch-icon" href="/images/logo_icon.png" />
<title>판다마켓</title>
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="/init.css" />
<link rel="stylesheet" href="style.css" />
</head>
<body>
<header>
<a href="/"><img src="/images/logo_sm.png" alt="판다마켓 바로가기" /></a>
<a class="head-login" href="/login.html">로그인</a>
Comment on lines +20 to +21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특정 경로로 이동하는 경우에 <a/> 태그 사용하시고, 이미지 요소에 유의미한 대체 텍스트 잘 넣으셨네요. 👍

</header>
<main>
<section class="banner">
<div class="banner-content">
<span>일상의 모든 물건을<br />거래해 보세요</span>
<a href="/items.html">구경하러 가기</a>
</div>
<img src="/images/panda_1.png" alt="" />
</section>
Comment on lines +23 to +30
Copy link
Collaborator

@hoody-jellybean hoody-jellybean Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<main/>, <section/> 시멘틱 태그 사용하신 것 좋습니다!
각 섹션에서 제목 요소는 Heading Element 사용하셔서 작성하셔도 좋을 것 같아요.

<section class="cards">
<div class="card">
<img src="/images/explain_1.png" alt="" />
<div class="card-content">
<span class="keyword">Hot Item</span>
<span class="title">인기 상품을<br />확인해 보세요</span>
Copy link
Collaborator

@hoody-jellybean hoody-jellybean Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금은 html 문서를 직접 작성하셔서 줄바꿈 문자를 삽입하기 어려우시겠지만,
나중에 React 등 UI 라이브러리나 프레임워크 사용하실 때에는, 줄바꿈 문자 사용 시 문단을 바꾸어주는 white-space: pre-line 같은 속성을 사용하셔도 됩니다!

참고차 알아두시면 될 것 같습니다~!!

토스 랜딩 페이지 보시면 실제로 어떻게 쓰고 있는지 보실 수 있어요~

<span class="sub">
가장 HOT한 중고거래 물품을<br />판다 마켓에서 확인해 보세요
</span>
</div>
</div>
<div class="card">
<div class="card-content">
<span class="keyword">Serch</span>
<span class="title">구매를 원하는<br />상품을 검색하세요</span>
<span class="sub">
구매하고 싶은 물품은 검색해서<br />쉽게 찾아보세요
</span>
</div>
<img src="/images/explain_2.png" alt="" />
</div>
<div class="card">
<img src="/images/explain_3.png" alt="" />
<div class="card-content">
<span class="keyword">Register</span>
<span class="title">판매를 원하는<br />상품을 등록하세요</span>
<span class="sub">
어떤 물건이든 판매하고 싶은<br />상품을 쉽게 등록하세요
</span>
</div>
</div>
</section>
<section class="banner">
<div class="banner-content">
<span>믿을 수 있는<br />판다마켓 중고 거래</span>
</div>
<img src="/images/panda_2.png" alt="" />
</section>
</main>
<footer>
<div class="foot-copy">
<span>&copy;codeit - 2024</span>
</div>
<div class="foot-link">
<a href="/privacy.html">Privacy Policy</a>
<a href="/faq.html">FAQ</a>
</div>
<div class="foot-sns">
<a href="http://www.facebook.com" target="_blank">
<img src="/images/facebook.png" alt="페이스북 바로가기" />
</a>
<a href="http://twitter.com" target="_blank">
<img src="/images/twitter.png" alt="트위터 바로가기" />
</a>
<a href="http://www.youtube.com" target="_blank">
<img src="/images/youtube.png" alt="유튜브 바로가기" />
</a>
<a href="http://www.instagram.com" target="_blank">
<img src="/images/instagram.png" alt="인스타그램 바로가기" />
</a>
Comment on lines +79 to +90
Copy link
Collaborator

@hoody-jellybean hoody-jellybean Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이콘 요소는 픽셀 이미지 대신 벡터 이미지 사용 가능하시면, SVG 이미지로 사용하는걸 추천드립니다!
(브라우저에서 렌더링될 때 선명하게 보이고, 크기 조절이 용이합니다.)

</div>
</footer>
</body>
</html>
61 changes: 61 additions & 0 deletions init.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위클리 과제에서 제공하는 디자인 시스템의 파운데이션을 변수로 가져와 사용하시는 것 너무 좋네요! 👍

Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
:root {
/* Color - Primary */
--blue-100: #3682ff;
--blue-200: #1967d6;
--blue-300: #1251aa;

/* Color - Secondary */
--gray-50: #f9fafb;
--gray-100: #f3f4f6;
--gray-200: #e5e7eb;
--gray-400: #9ca3af;
--gray-500: #6b7280;
--gray-600: #4b5563;
--gray-700: #374151;
--gray-800: #1f2937;
--gray-900: #111827;

/* Color - Error */
--red: #f74747;
}

:root {
/* Font - Size */
--size-4xl: 40px;
--size-3xl: 32px;
--size-2xl: 24px;
--size-xl: 20px;
--size-2lg: 18px;
--size-lg: 16px;
--size-md: 14px;
--size-sm: 13px;
--size-xs: 12px;

/* Font - Line Height */
--line-4xl: 52px;
--line-3xl: 42px;
--line-2xl: 32px;
--line-xl: 32px;
--line-2lg: 26px;
--line-lg: 26px;
--line-md: 24px;
--line-sm: 22px;
--line-xs: 18px;
}

body {
padding: 0;
margin: 0;
font-family: "Pretendard", sans-serif;
}

:link,
:active,
:visited {
color: black;
text-decoration: none;
}

:is(a, button):hover {
cursor: pointer;
}
Comment on lines +59 to +61
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 is 선택자는 처음 보네요. 이렇게 적극적으로 다양한 선택자 사용해보시는 것 너무 좋습니다. 👍

21 changes: 21 additions & 0 deletions items.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="icon" href="/images/logo_icon.png" />
<link rel="apple-touch-icon" href="/images/logo_icon.png" />
<title>판다마켓</title>
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="/init.css" />
<link rel="stylesheet" href="style.css" />
</head>
<body>
<h1>Items</h1>
</body>
</html>
21 changes: 21 additions & 0 deletions login.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="icon" href="/images/logo_icon.png" />
<link rel="apple-touch-icon" href="/images/logo_icon.png" />
<title>판다마켓</title>
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="/init.css" />
<link rel="stylesheet" href="style.css" />
</head>
<body>
<h1>Log In</h1>
</body>
</html>
21 changes: 21 additions & 0 deletions privacy.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="icon" href="/images/logo_icon.png" />
<link rel="apple-touch-icon" href="/images/logo_icon.png" />
<title>판다마켓</title>
<link
rel="stylesheet"
as="style"
crossorigin
href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"
/>
<link rel="stylesheet" href="/init.css" />
<link rel="stylesheet" href="style.css" />
</head>
<body>
<h1>Privacy</h1>
</body>
</html>
Loading
Loading