Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[김지윤] Sprint1 #11

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions css/components/footer.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
.footer__wrap {
background: var(--Secondary-900);
padding: 32px 400px;
}

.footer__content {
display: flex;
justify-content: space-between;
align-items: flex-start;
}

.footer__copyright {
color: var(--Secondary-400);
text-align: center;

font-size: 16px;
font-weight: 400;
line-height: normal;
}

.footer__info-wrap {
display: flex;
justify-content: space-between;
}

.footer__info {
text-decoration: none;
color: var(--Secondary-200);
text-align: center;

font-size: 16px;
font-weight: 400;
line-height: normal;
}

.footer__info:first-child {
margin: 0 30px 0 0;
}

.footer__shortcut-btns {
display: flex;
justify-content: center;
align-items: center;
}

.footer__shortcut-btn {
display: flex;
}

.footer__shortcut-btn:not(:last-child) {
margin: 0 12px 0 0;
}
31 changes: 31 additions & 0 deletions css/components/header.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
.header__wrap {
border-bottom: 1px solid #dfdfdf;
}

.header__content {
display: flex;
justify-content: space-between;
align-items: center;
}

.header__logo {
display: flex;
}

/* Q. height의 높이가 차이 나는 이유?
div, div > a !== div > a > img
height = 55 !== 51
display: inline-block or flex로 해결 */
Comment on lines +15 to +18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3:
말씀해주신것처럼 해결해도 좋지만, 이는 a 태그 (인라인 태그) 안에 img 태그 (인라인 태그) 가 들어가며 vertical-align 속성의 영향을 받기 때문에 수직정렬이 의도하지 않게 적용되는 현상입니다.
따라서 display: flex 보다 아래와 같이 처리하시는 걸 추천드립니다.

.header__login-btn img {
  vertical-align: middle;
}


.header__login-btn {
text-decoration: none;
padding: 12px 23px;
border-radius: 8px;
color: var(--Secondary-100);
background-color: var(--Primary-100);

/* pretendard/lg-16px-semibold */
font-size: 16px;
font-weight: 600;
line-height: 26px;
}
126 changes: 126 additions & 0 deletions css/screens/landing-page.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
.landing-vertical {
display: flex;
justify-content: center;
align-items: flex-end;
height: 540px;
background: #cfe5ff;
}

.landing-vertical__wrap {
display: flex;
justify-content: space-between;
align-items: center;
margin: 200px 405px 0 405px;
}

.landing-vertical__content {
display: flex;
flex-direction: column;
padding: 0 0 60px 0;
gap: 32px;
}

.landing-vertical__title {
color: var(--Secondary-700);
font-size: 40px;
font-weight: 700;
line-height: 140%; /* 56px */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3:
아래와 동일한 표현입니다.

Suggested change
line-height: 140%; /* 56px */
line-height: 1.4;

margin: 0;
}

.landing-vertical__btn-link {
text-decoration: none;
display: flex;
justify-content: center;
align-items: center;
gap: 10px;
height: 56px;
border-radius: 40px;
padding: 16px 124px;
color: var(--Secondary-50);
background-color: var(--Primary-100);
}

.landing-vertical__btn-text {
/* pretendard/xl-20px-semibold */
font-size: 20px;
font-weight: 600;
line-height: 32px;
}

.landing-vertical__wrap--bottom {
gap: 69px;
}

.landing-main {
background-color: #fcfcfc;
padding: 0 0 138px 0;
}

.landing-main__wrap {
display: flex;
background-color: #ffffff;
}

.landing-main__wrap:first-child {
padding: 138px 605px 138px 360px;
}

.landing-main__wrap--right {
justify-content: flex-end;
padding: 138px 360px 138px 591px;
}

.landing-main__wrap:last-child {
padding: 138px 573px 138px 360px;
}

.landing-main__card {
display: flex;
align-items: center;
background: #fcfcfc;
gap: 64px;
}

.landing-main__card--right {
justify-content: flex-end;
}

.landing-main__content {
display: flex;
flex-direction: column;
}

.landing-main__content--right {
text-align: right;
}

.landing-main__keyword {
color: var(--Primary-100);

/* pretendard/2lg-18px-bold */
font-size: 18px;
font-weight: 700;
line-height: 26px;
margin: 0;
}

.landing-main__title {
color: var(--Secondary-700);
margin: 12px 0 24px;

font-size: 40px;
font-weight: 700;
line-height: 140%;
letter-spacing: 0.8px;
}

.landing-main__desc {
color: var(--Secondary-700);
margin: 0;

/* pretendard/2xl-24px-medium */
font-size: 24px;
font-weight: 500;
line-height: 32px;
}
45 changes: 45 additions & 0 deletions css/styles.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
@import "variables.css";

/* components */
@import "components/header.css";
@import "components/footer.css";

/* screens */
@import "screens/landing-page.css";

* {
box-sizing: border-box;
}

html {
width: 100vw;
overflow-x: hidden;
}

body {
margin: 0;
font-family: Pretendard;
font-style: normal;
}

.landing-vertical__wrap,
.landing-main__wrap,
.footer__wrap {
text-wrap: nowrap;
}

@media (min-width: 1920px) {
.header__wrap {
padding: 9px 400px;
}
}

@media (max-width: 1919px) {
.header__wrap {
padding: 9px 200px;
}
}

/* Q. header__wrap에 padding: 9px 200px을,
@media (min-width: 1920px)로 9px 400px을 할당했을 때
미디어 쿼리가 작동하지 않는 이유? */
17 changes: 17 additions & 0 deletions css/variables.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
:root {
/* Primary color */
--Primary-100: #3692ff;
--Primary-200: #1967d6;
--Primary-300: #1251aa;
Comment on lines +2 to +5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3:
사소한거지만 primary color는 오름차순, secondary color는 내림차순인게 조금 신경쓰이네요.
기왕이면 같은 방식으로 정렬되면 좋을 것 같습니다.


/* Secondary color */
--Secondary-900: #111827;
--Secondary-800: #1f2937;
--Secondary-700: #374151;
--Secondary-600: #4b5563;
--Secondary-500: #6b7280;
--Secondary-400: #9ca3af;
--Secondary-200: #e5e7eb;
--Secondary-100: #f3f4f6;
--Secondary-50: #f9fafb;
}
Empty file added faq.html
Empty file.
Binary file added images/footer/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/footer/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/footer/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/footer/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/header/Property 1=sm.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1:
이미지 명에 공백은 들어가지 않는 것이 좋습니다.
또한 어떤 이미지인지 알 수 있는 이름(logo.png)이면 좋을 것 같습니다.
https://www.webauthorings.com/spaces-in-image-names-file-names/

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/header/Property [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/header/Property [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/main/Img_home_01.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2:
이미지 명들의 규칙이 통일되면 좋을 것 같습니다.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/main/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/main/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/main/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/main/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading