fix: unify the logged output of the task result #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12870767779Details
💛 - Coveralls |
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
|
Fixed. Not sure why rector is always failing at first and I have to run it again. Maybe we should add these lines to the file in this repo: https://github.com/codeigniter4/.github/blob/main/.github/workflows/rector.yml#L22-L27 |
paulbalandan
approved these changes
Jan 20, 2025
|
It seems it already uses the concurrency thing as it inherits from the |
|
Thank you! I had to manually restart the rector and now it went in no time 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the task result cannot always be logged properly.
Fixes #179
Checklist: