fix: now() throws error when using SQLite3 DBDriver #9228
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DatabaseHandler uses the now() function for timestamp generation which is MySQL specific. This means that when using the DatabaseHandler for sessions and using the SQLite3 driver the functions that use now() will throw an exception. The proposed fix checks which DBDriver is being used, and if it's SQLite3 uses the datetime('now') function instead of now().
Checklist: