don't use .to_i to avoid different usec being considered equal #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
(required) Please include any relevant details about this Pull Request, with a focus on:
Different times being considered equal.
Why did you do things this way.
The previous implementation used .to_i to compare dates, this lead to a bug where a model would pass validation without actually being valid.
How does it fix the issue at hand.
Just changed the implementation to compare dates without .to_i
Based on the test suite, it looks fine.