Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huawei HMS- Remove 'Require GMS' dialog for HMS phone user #56

Open
wants to merge 1 commit into
base: align-master
Choose a base branch
from

Conversation

minUswachoke
Copy link

This version only remove the dialog "GMS unavailable" from onboarding stage. Not in the mainpage, since that have to fix the location issue and might effect alot of code. What I did

  1. Add Native module to check for HMS and GMS phone
  2. The dialog come from the method backgroundTracking.start()
  3. I cover the method checking if the phone is IOS or having GMS in the android phone to use the method
  4. Requesting background location somehow didnt work in request method, this also doesnt work in normal build. But 'backgroundTracking.start() is requesting it.
  5. HMS phone will not be requesting for location

… stage. Not in the mainpage, since that have to fix the location issue and might effect alot of code. What I did

1. Add Native module to check for HMS and GMS phone
 2. The dialog come from the method backgroundTracking.start()
3. I cover the method checking if the phone is IOS or having GMS in the android phone to use the method
4. Requesting background location somehow didnt work in request method, this also doesnt work in normal build. But 'backgroundTracking.start() is requesting it.
5. HMS phone will not be requesting for location
@PaperMonster
Copy link
Contributor

PaperMonster commented Jan 13, 2021

I think master is the better branch to merge into, at least until Code of Conduct and Contribution Guideline is announced.

There is another indirect reference to backgroundTracking.start() in App.tsx via backgroundTracking.setup().

BTW, what do you think about react-native-device-info's hasGms()? If it works, it would be good idea to use this method as react-native-device-info is already in app's dependencies.

@n3tr
Copy link
Collaborator

n3tr commented Jan 14, 2021

Would be great If we can achieve the same result by using react-native-device-info. (here is the checking code from rn-device-info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants