Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter subscription added #1687

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

SamuelBuhan
Copy link
Contributor

Summary

Add the subscription link for the newsletter to the homepage.

Checklist

  • On the frontend, I've added the newsletter redirection in the header.
  • On the frontend, I've added the newsletter redirection in the footer.

Screenshots

Screenshot 2025-01-21 at 21 23 38 Screenshot 2025-01-21 at 20 50 50

Known issues

This PR solve the issue : Add Newsletter Signup to Site #1671

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:54am

@SamuelBuhan
Copy link
Contributor Author

SamuelBuhan commented Jan 28, 2025

I run npx prettier --write . to have the correct formatting

@mvictor55
Copy link
Collaborator

The text, in both places, should be "Click Here to Subscribe to Our Newsletter"

  • Please mirror the capitalized letters
  • Please make the entire text a hyperlink, not just the "Our Newsletter" text

@SamuelBuhan
Copy link
Contributor Author

Update done. Should be fine now !

Screenshot 2025-01-28 at 19 39 48 Screenshot 2025-01-28 at 19 40 15

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mephistic Mephistic merged commit 75cedf7 into codeforboston:main Jan 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants