Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

248 styling #266

Merged
merged 6 commits into from
Nov 6, 2024
Merged

248 styling #266

merged 6 commits into from
Nov 6, 2024

Conversation

dwindleduck
Copy link
Collaborator

Complete:

  • added the total periods to the denominator of Number of Periods Included
  • added static help icon images in three locations (should create a reusable component?)
  • updated some styling to more closely match the design

Still needs attention:

  • thousand commas on Whole-home UA BTU (use browser locale functionality or d3format)
  • tailwind's border radius utilities (rounded-md) not yet working

Copy link
Collaborator

@plocket plocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thanks for the svgs too! I think we should fix the import statements (though I'm not sure which are related to this PR). [The ones that the GitHub bot is marking on the "Files" page.] I also strongly feel we should either add the help text or comment out the help circle images for now. There's also one typo I saw. I'm leaving this as a comment, though, in case others feel differently.

@thadk
Copy link
Member

thadk commented Nov 6, 2024

image

@thadk thadk merged commit 6bde273 into codeforboston:main Nov 6, 2024
8 checks passed
@thadk
Copy link
Member

thadk commented Nov 6, 2024

Will fix pre-existing import warnings on another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants